cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-12 02:32:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] GBP Tweaks (#2143)

Browse Source 
* GBP Tweaks (#55441)

Some rescaling since the stakes are 10x higher now:

    Fix: +3
    Tweak: -2
    Performance: +12
    Priority: High: +15
    Priority: Critical: +20
    Feedback: +2
    Code Improvement: +2

The intention with the formula tweak is for the highest absolute value of the label set (favoring the negative) to be applied.

* GBP Tweaks

Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com>
This commit is contained in:
SkyratBot
2020-12-12 12:05:15 +01:00
committed by GitHub
parent 988dab168e
commit 988622a270
1 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tools/WebhookProcessor/github_webhook_processor.php
View File

@@ -35,7 +35,7 @@ $path_to_script = 'tools/WebhookProcessor/github_webhook_processor.php';
$tracked_branch = "master";
$trackPRBalance = true;
$prBalanceJson = '';
$startingPRBalance = 5;
$startingPRBalance = 30;
$maintainer_team_id = 133041;
$validation = "org";
$validation_count = 1;
@@ -643,36 +643,38 @@ function get_pr_code_friendliness($payload, $oldbalance = null){
$labels = get_pr_labels_array($payload);
//anything not in this list defaults to 0
$label_values = array(
'Fix' => 2,
'Fix' => 3,
'Refactor' => 10,
'Code Improvement' => 1,
'Code Improvement' => 2,
'Grammar and Formatting' => 1,
'Priority: High' => 4,
'Priority: CRITICAL' => 5,
'Priority: High' => 15,
'Priority: CRITICAL' => 20,
'Unit Tests' => 6,
'Logging' => 1,
'Feedback' => 1,
'Performance' => 3,
'Feedback' => 2,
'Performance' => 12,
'Feature' => -10,
'Balance/Rebalance' => -8,
'PRB: Reset' => $startingPRBalance - $oldbalance,
'Tweak' => -2,
'GBP: Reset' => $startingPRBalance - $oldbalance,
);
$affecting = 0;
$is_neutral = FALSE;
$found_something_positive = false;
$maxNegative = 0;
$maxPositive = 0;
foreach($labels as $l){
if($l == 'PRB: No Update') { //no effect on balance
$affecting = 0;
break;
if($l == 'GBP: No Update') { //no effect on balance
return 0;
}
else if(isset($label_values[$l])) {
$friendliness = $label_values[$l];
if($friendliness > 0)
$found_something_positive = true;
$affecting = $found_something_positive ? max($affecting, $friendliness) : $friendliness;
$maxPositive = max($friendliness, $maxPositive);
else
$maxNegative = min($friendliness, $maxNegative);
}
}
$affecting = abs($maxNegative) >= $maxPositive ? $maxNegative : $maxPositive;
return $affecting;
}