From 9bde02b355bd9c6955ae54efb832f577d733b9f3 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Mon, 5 Feb 2024 21:18:07 +0100 Subject: [PATCH] [MIRROR] Don't gain every faction of a mob you make sentient (#26350) * Don't gain every faction of a mob you make sentient (#81274) ## About The Pull Request Fixes #80548 Repro steps for linked bug were actually much _simpler_ than the reporter thought. Steps required to make yourself permanently passive to megafauna: - Acquire sentience potion - Successfully make any mining mob sentient That's it! This is because for some reason the `enslave_mind_to_creator`'s faction manipulation was _mutual_. It would not only give your new minion all of your factions... but you all of theirs as well. I don't see why making a Goliath sentient should make every mining mob treat you as a friend for the rest of the round, so now it won't do that. Frankly I'm not even sure that the enslaved mob should keep all of their old factions either, maybe it should just hard copy yours... I'm not making that change in this PR though. ## Changelog :cl: fix: Making a mob sentient no longer gives you all of their factions. /:cl: * Don't gain every faction of a mob you make sentient --------- Co-authored-by: Jacquerel --- code/datums/mind/antag.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/datums/mind/antag.dm b/code/datums/mind/antag.dm index f95b1992c0d..b6179b5fc58 100644 --- a/code/datums/mind/antag.dm +++ b/code/datums/mind/antag.dm @@ -216,7 +216,7 @@ enslaved_to = WEAKREF(creator) current.faction |= creator.faction - creator.faction |= current.faction + creator.faction |= "[REF(current)]" current.log_message("has been enslaved to [key_name(creator)].", LOG_GAME) log_admin("[key_name(current)] has been enslaved to [key_name(creator)].")