TGUI list conversions + bug fixes (#63354)

About The Pull Request

    Converts more inputs to TGUI. Possibly all user-facing input lists in the game.
    Did any surrounding text/number inputs as well
    Added null choice support so users can press cancel.
    Added some misc TGUI input fixes
    Fixed custom vendors while I was there

I refactored a lot of code while just poking around.
Primarily, usage of .len in files where I was already working on lists.
Some code was just awful - look at guardian.dm and its non use of early returns
If there are any disputes, I can revert it just fine, those changes are not integral to the PR.
Why It's Good For The Game

Fixes #63629
Fixes #63307
Fixes custom vendors /again/
Text input is more performant.
Part of a long series of TGUI conversion to make the game more visually appealing
Changelog

cl
refactor: The majority of user facing input lists have been converted to TGUI.
refactor: Tgui text inputs now scale with entered input.
fix: Many inputs now properly accept cancelling out of the menu.
fix: Fixes an edge case where users could not press enter on number inputs.
fix: Custom vendor bluescreen.
fix: You can now press ENTER on text inputs without an entry to cancel.
/cl

code/modules/mining/equipment/marker_beacons.dm

@@ -62,12 +62,13 @@ GLOBAL_LIST_INIT(marker_beacon_colors, sort_list(list(
 /obj/item/stack/marker_beacon/AltClick(mob/living/user)
 	if(!istype(user) || !user.canUseTopic(src, BE_CLOSE))
 		return
-	var/input_color = input(user, "Choose a color.", "Beacon Color") as null|anything in GLOB.marker_beacon_colors
+	var/input_color = tgui_input_list(user, "Choose a color", "Beacon Color", GLOB.marker_beacon_colors)
+	if(isnull(input_color))
+		return
 	if(!istype(user) || !user.canUseTopic(src, BE_CLOSE))
 		return
-	if(input_color)
-		picked_color = input_color
-		update_appearance()
+	picked_color = input_color
+	update_appearance()
 
 /obj/structure/marker_beacon
 	name = "marker beacon"
@@ -148,12 +149,13 @@ GLOBAL_LIST_INIT(marker_beacon_colors, sort_list(list(
 	..()
 	if(!istype(user) || !user.canUseTopic(src, BE_CLOSE))
 		return
-	var/input_color = input(user, "Choose a color.", "Beacon Color") as null|anything in GLOB.marker_beacon_colors
+	var/input_color = tgui_input_list(user, "Choose a color", "Beacon Color", GLOB.marker_beacon_colors)
+	if(isnull(input_color))
+		return
 	if(!istype(user) || !user.canUseTopic(src, BE_CLOSE))
 		return
-	if(input_color)
-		picked_color = input_color
-		update_appearance()
+	picked_color = input_color
+	update_appearance()
 
 
 /* Preset marker beacon types, for mapping */

code/modules/mining/fulton.dm

@@ -19,23 +19,17 @@ GLOBAL_LIST_EMPTY(total_extraction_beacons)
 
 /obj/item/extraction_pack/attack_self(mob/user)
 	var/list/possible_beacons = list()
-	for(var/B in GLOB.total_extraction_beacons)
-		var/obj/structure/extraction_point/EP = B
-		if(EP.beacon_network in beacon_networks)
-			possible_beacons += EP
-
-	if(!possible_beacons.len)
+	for(var/obj/structure/extraction_point/extraction_point as anything in GLOB.total_extraction_beacons)
+		if(extraction_point.beacon_network in beacon_networks)
+			possible_beacons += extraction_point
+	if(!length(possible_beacons))
 		to_chat(user, span_warning("There are no extraction beacons in existence!"))
 		return
-
 	else
-		var/A
-
-		A = input("Select a beacon to connect to", "Balloon Extraction Pack", A) as null|anything in sort_names(possible_beacons)
-
-		if(!A)
+		var/chosen_beacon = tgui_input_list(user, "Beacon to connect to", "Balloon Extraction Pack", sort_names(possible_beacons))
+		if(isnull(chosen_beacon))
 			return
-		beacon = A
+		beacon = chosen_beacon
 		to_chat(user, span_notice("You link the extraction pack to the beacon system."))
 
 /obj/item/extraction_pack/afterattack(atom/movable/A, mob/living/carbon/human/user, flag, params)

code/modules/mining/machine_redemption.dm

@@ -284,7 +284,7 @@
 				if (params["sheets"])
 					desired = text2num(params["sheets"])
 				else
-					desired = tgui_input_number(usr, "How many sheets would you like to smelt?", "Smelt")
+					desired = tgui_input_number(usr, "How many sheets would you like to smelt?", "Smelt", 1, stored_amount, 1)
 					if(isnull(desired))
 						return
 					desired = round(desired)
@@ -334,7 +334,7 @@
 				if (params["sheets"])
 					desired = text2num(params["sheets"])
 				else
-					desired = tgui_input_number(usr, "How many sheets would you like to smelt?", "Smelt")
+					desired = tgui_input_number(usr, "How many sheets would you like to smelt?", "Smelt", 1, smelt_amount, 1)
 					if(isnull(desired))
 						return
 					desired = round(desired)

code/modules/mining/machine_vending.dm

@@ -169,8 +169,10 @@
 /obj/machinery/mineral/equipment_vendor/proc/RedeemVoucher(obj/item/mining_voucher/voucher, mob/redeemer)
 	var/items = list("Survival Capsule and Explorer's Webbing", "Resonator Kit", "Minebot Kit", "Extraction and Rescue Kit", "Crusher Kit", "Mining Conscription Kit")
 
-	var/selection = input(redeemer, "Pick your equipment", "Mining Voucher Redemption") as null|anything in sort_list(items)
-	if(!selection || !Adjacent(redeemer) || QDELETED(voucher) || voucher.loc != redeemer)
+	var/selection = tgui_input_list(redeemer, "Pick your equipment", "Mining Voucher Redemption", sort_list(items))
+	if(isnull(selection))
+		return
+	if(!Adjacent(redeemer) || QDELETED(voucher) || voucher.loc != redeemer)
 		return
 	var/drop_location = drop_location()
 	switch(selection)