cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-19 20:15:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

TGUI list conversions + bug fixes (#63354)

Browse Source 
About The Pull Request

    Converts more inputs to TGUI. Possibly all user-facing input lists in the game.
    Did any surrounding text/number inputs as well
    Added null choice support so users can press cancel.
    Added some misc TGUI input fixes
    Fixed custom vendors while I was there

I refactored a lot of code while just poking around.
Primarily, usage of .len in files where I was already working on lists.
Some code was just awful - look at guardian.dm and its non use of early returns
If there are any disputes, I can revert it just fine, those changes are not integral to the PR.
Why It's Good For The Game

Fixes #63629
Fixes #63307
Fixes custom vendors /again/
Text input is more performant.
Part of a long series of TGUI conversion to make the game more visually appealing
Changelog

cl
refactor: The majority of user facing input lists have been converted to TGUI.
refactor: Tgui text inputs now scale with entered input.
fix: Many inputs now properly accept cancelling out of the menu.
fix: Fixes an edge case where users could not press enter on number inputs.
fix: Custom vendor bluescreen.
fix: You can now press ENTER on text inputs without an entry to cancel.
/cl
This commit is contained in:
Jeremiah
2021-12-30 14:07:28 -08:00
committed by GitHub
parent 6162daf1cb
commit 9c6fdb567d
153 changed files with 1196 additions and 986 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/wiremod/components/admin/input_request.dm
+6 -6
View File
@@ -59,21 +59,21 @@
var/new_option = input_options.value
switch(new_option)
if(COMP_INPUT_STRING)
var/player_input = input(player, "Input a value", "Input value") as null|text
if(!player_input)
var/player_input = tgui_input_text(player, "Input a value", "Input value")
if(isnull(player_input))
return
input_response.set_output(player_input)
if(COMP_INPUT_NUMBER)
var/player_input = input(player, "Input a value", "Input value") as null|num
if(!player_input)
var/player_input = tgui_input_number(player, "Input a value", "Input value")
if(isnull(player_input))
return
input_response.set_output(player_input)
if(COMP_INPUT_LIST)
var/list/data = parameter.value
if(!islist(data))
return
var/player_input = input(player, "Input a value", "Input value") as null|anything in data
if(!player_input)
var/player_input = tgui_input_list(player, "Input a value", "Input value", data)
if(isnull(player_input))
return
input_response.set_output(player_input)
input_triggered.set_output(COMPONENT_SIGNAL)