Service achievement not being in end of round report (#92743)

## About The Pull Request

Fixes #92457 

Moves it a little earlier in the process so that the service achievement
awarded it ends up in the end of round report.
## Why It's Good For The Game

- Fixes a possible oversight
- Players get to celebrate, yay.
This commit is contained in:
SimplyLogan
2025-08-29 21:19:51 +01:00
committed by GitHub
parent 13fea26c39
commit 9d51ad7acc

View File

@@ -526,18 +526,25 @@ GLOBAL_LIST_INIT(achievements_unlocked, list())
parts += "The [venue] served [venue.customers_served] customer\s and made [venue.total_income] credits.<br>"
parts += "In total, they earned [tourist_income] credits[tourist_income ? "!" : "..."]<br>"
log_econ("Roundend service income: [tourist_income] credits.")
// Award service achievements based on tourist income
switch(tourist_income)
if(1 to 2000)
award_service(/datum/award/achievement/jobs/service_bad)
if(2001 to 4999)
award_service(/datum/award/achievement/jobs/service_okay)
if(5000 to INFINITY)
award_service(/datum/award/achievement/jobs/service_good)
switch(tourist_income)
if(0)
parts += "[span_redtext("Service did not earn any credits...")]<br>"
if(1 to 2000)
parts += "[span_redtext("Centcom is displeased. Come on service, surely you can do better than that.")]<br>"
award_service(/datum/award/achievement/jobs/service_bad)
if(2001 to 4999)
parts += "[span_greentext("Centcom is satisfied with service's job today.")]<br>"
award_service(/datum/award/achievement/jobs/service_okay)
else
parts += "<span class='reallybig greentext'>Centcom is incredibly impressed with service today! What a team!</span><br>"
award_service(/datum/award/achievement/jobs/service_good)
parts += "<b>General Statistics:</b><br>"
parts += "There were [station_vault] credits collected by crew this shift.<br>"
@@ -548,7 +555,7 @@ GLOBAL_LIST_INIT(achievements_unlocked, list())
parts += "The most affluent crew member at shift end was <b>[mr_moneybags.account_holder] with [mr_moneybags.account_balance]</b> cr!</div>"
else
parts += "Somehow, nobody made any money this shift! This'll result in some budget cuts...</div>"
return parts
return parts.Join()
/**
* Awards the service department an achievement and updates the chef and bartender's highscore for tourists served.