cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-29 08:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

First pass at a qdel() garbage collection system for tgstation

Browse Source 
Works pretty well. If it can't GC something, it'll just del() it and be done.
Speed is amazing, holy shit.

New procs you should be aware of:
qdel(atom/movable) - sets up an object for garbage collection. Call this rather than del(atom/movable).
atom/movable/Destroy() - called right before the object is GC'd, so it still has a loc. Also called if the object is del()'d.
new controller - garbage.dm has all the details on this. Basically it nulls all references on GC'd objects and force del() them if necessary.
Generally speaking, objects should use Destroy() for behavior prior to deletion rather than Del(). You should also always call the parent so the object gets the right gc_destroyed var set.

ISSUES:
Tries to GC mobs atm. This actually works for new players, not so much for humans/monkies/simple_animals/anything. I'm guessing it needs to clear out their mind and HUD and maybe other things.
Gibbing is really bugged. It works, but the overlays just sit there for awhile and ugh. I'm very tempted just to del() mob/living and mob/camera and call it a day.
qdel() equipment doesn't unequip the item.
Pipes don't generally GC correctly. Debugging suggests they get referenced in many pipenets and that isn't cleared properly. However some do work fine. Need assistance here.
Bots don't GC, probably in the radio controller.
Lots of other shit doesn't GC but it's hard to find them because of the pipe spam.
I think I'm calling Destroy() twice by accident.
This commit is contained in:
MrPerson
2014-02-23 14:55:12 -08:00
parent 2979e26798
commit 9eee3e5067
432 changed files with 2672 additions and 2569 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/WorkInProgress/Sigyn/Department Sec/jobs.dm
+22 -22
View File
@@ -3,8 +3,8 @@ var/list/sec_departments = list("engineering", "supply", "medical", "science")
/datum/job/officer/proc/assign_sec_to_department(var/mob/living/carbon/human/H)
if(!H) return 0
if(!sec_departments.len)
H.equip_to_slot_or_del(new /obj/item/clothing/under/rank/security(H), slot_w_uniform)
H.equip_to_slot_or_del(new /obj/item/device/radio/headset/headset_sec(H), slot_ears)
H.equip_to_slot_or_qdel(new /obj/item/clothing/under/rank/security(H), slot_w_uniform)
H.equip_to_slot_or_qdel(new /obj/item/device/radio/headset/headset_sec(H), slot_ears)
else
var/department = pick(sec_departments)
sec_departments -= department
@@ -12,23 +12,23 @@ var/list/sec_departments = list("engineering", "supply", "medical", "science")
var/destination = null
switch(department)
if("supply")
H.equip_to_slot_or_del(new /obj/item/clothing/under/rank/security/cargo(H), slot_w_uniform)
H.equip_to_slot_or_del(new /obj/item/device/radio/headset/headset_sec/department/supply(H), slot_ears)
H.equip_to_slot_or_qdel(new /obj/item/clothing/under/rank/security/cargo(H), slot_w_uniform)
H.equip_to_slot_or_qdel(new /obj/item/device/radio/headset/headset_sec/department/supply(H), slot_ears)
dep_access = list(access_mailsorting, access_mining)
destination = /area/security/checkpoint/supply
if("engineering")
H.equip_to_slot_or_del(new /obj/item/clothing/under/rank/security/engine(H), slot_w_uniform)
H.equip_to_slot_or_del(new /obj/item/device/radio/headset/headset_sec/department/engi(H), slot_ears)
H.equip_to_slot_or_qdel(new /obj/item/clothing/under/rank/security/engine(H), slot_w_uniform)
H.equip_to_slot_or_qdel(new /obj/item/device/radio/headset/headset_sec/department/engi(H), slot_ears)
dep_access = list(access_construction, access_engine)
destination = /area/security/checkpoint/engineering
if("medical")
H.equip_to_slot_or_del(new /obj/item/clothing/under/rank/security/med(H), slot_w_uniform)
H.equip_to_slot_or_del(new /obj/item/device/radio/headset/headset_sec/department/med(H), slot_ears)
H.equip_to_slot_or_qdel(new /obj/item/clothing/under/rank/security/med(H), slot_w_uniform)
H.equip_to_slot_or_qdel(new /obj/item/device/radio/headset/headset_sec/department/med(H), slot_ears)
dep_access = list(access_medical)
destination = /area/security/checkpoint/medical
if("science")
H.equip_to_slot_or_del(new /obj/item/clothing/under/rank/security/science(H), slot_w_uniform)
H.equip_to_slot_or_del(new /obj/item/device/radio/headset/headset_sec/department/sci(H), slot_ears)
H.equip_to_slot_or_qdel(new /obj/item/clothing/under/rank/security/science(H), slot_w_uniform)
H.equip_to_slot_or_qdel(new /obj/item/device/radio/headset/headset_sec/department/sci(H), slot_ears)
dep_access = list(access_research)
destination = /area/security/checkpoint/science
var/teleport = 0
@@ -64,21 +64,21 @@ var/list/sec_departments = list("engineering", "supply", "medical", "science")
equip(var/mob/living/carbon/human/H)
if(!H) return 0
if(H.backbag == 2) H.equip_to_slot_or_del(new /obj/item/weapon/storage/backpack/security(H), slot_back)
if(H.backbag == 3) H.equip_to_slot_or_del(new /obj/item/weapon/storage/backpack/satchel_sec(H), slot_back)
if(H.backbag == 2) H.equip_to_slot_or_qdel(new /obj/item/weapon/storage/backpack/security(H), slot_back)
if(H.backbag == 3) H.equip_to_slot_or_qdel(new /obj/item/weapon/storage/backpack/satchel_sec(H), slot_back)
assign_sec_to_department(H)
H.equip_to_slot_or_del(new /obj/item/clothing/shoes/jackboots(H), slot_shoes)
H.equip_to_slot_or_del(new /obj/item/device/pda/security(H), slot_belt)
H.equip_to_slot_or_del(new /obj/item/clothing/suit/armor/vest(H), slot_wear_suit)
H.equip_to_slot_or_del(new /obj/item/clothing/head/helmet(H), slot_head)
H.equip_to_slot_or_del(new /obj/item/weapon/handcuffs(H), slot_s_store)
H.equip_to_slot_or_del(new /obj/item/device/flash(H), slot_l_store)
H.equip_to_slot_or_qdel(new /obj/item/clothing/shoes/jackboots(H), slot_shoes)
H.equip_to_slot_or_qdel(new /obj/item/device/pda/security(H), slot_belt)
H.equip_to_slot_or_qdel(new /obj/item/clothing/suit/armor/vest(H), slot_wear_suit)
H.equip_to_slot_or_qdel(new /obj/item/clothing/head/helmet(H), slot_head)
H.equip_to_slot_or_qdel(new /obj/item/weapon/handcuffs(H), slot_s_store)
H.equip_to_slot_or_qdel(new /obj/item/device/flash(H), slot_l_store)
if(H.backbag == 1)
H.equip_to_slot_or_del(new /obj/item/weapon/storage/box/survival(H), slot_r_hand)
H.equip_to_slot_or_del(new /obj/item/weapon/handcuffs(H), slot_l_hand)
H.equip_to_slot_or_qdel(new /obj/item/weapon/storage/box/survival(H), slot_r_hand)
H.equip_to_slot_or_qdel(new /obj/item/weapon/handcuffs(H), slot_l_hand)
else
H.equip_to_slot_or_del(new /obj/item/weapon/storage/box/survival(H.back), slot_in_backpack)
H.equip_to_slot_or_del(new /obj/item/weapon/handcuffs(H), slot_in_backpack)
H.equip_to_slot_or_qdel(new /obj/item/weapon/storage/box/survival(H.back), slot_in_backpack)
H.equip_to_slot_or_qdel(new /obj/item/weapon/handcuffs(H), slot_in_backpack)
var/obj/item/weapon/implant/loyalty/L = new/obj/item/weapon/implant/loyalty(H)
L.imp_in = H
L.implanted = 1
code/WorkInProgress/buildmode.dm
+3 -3
View File
@@ -8,7 +8,7 @@
M.client.show_popup_menus = 1
for(var/obj/effect/bmode/buildholder/H)
if(H.cl == M.client)
del(H)
qdel(H)
else
log_admin("[key_name(usr)] has entered build mode.")
M.client.buildmode = 1
@@ -212,7 +212,7 @@
T.ChangeTurf(/turf/simulated/wall)
return
else if(istype(object,/obj))
del(object)
qdel(object)
return
else if(istype(object,/turf) && pa.Find("alt") && pa.Find("left"))
new/obj/machinery/door/airlock(get_turf(object))
@@ -242,7 +242,7 @@
var/obj/A = new holder.buildmode.objholder (get_turf(object))
A.dir = holder.builddir.dir
else if(pa.Find("right"))
if(isobj(object)) del(object)
if(isobj(object)) qdel(object)
if(3)
if(pa.Find("left")) //I cant believe this shit actually compiles.
code/WorkInProgress/carn/debug_pipenets.dm
+59
View File
@@ -0,0 +1,59 @@
/client/verb/pipenets_debug()
if(!holder) return
for(var/i=1,i<=pipe_networks.len,i++)
// src << "<a href='?"\ref[holder]";adminplayervars=\ref[powernets[i]]'>[copytext("\ref[powernets[i]]",8,12)]</A>"
src << "<A HREF='?_src_=vars;Vars=\ref[pipe_networks[i]]'>[copytext("\ref[pipe_networks[i]]",8,12)]</A>"
src << "[pipe_networks.len] total pipenets"
/client/verb/pipenet_overlays()
var/list/L = list()
for(var/obj/machinery/atmospherics/AT in view(mob))
AT.maptext = null
L |= AT
for(var/datum/pipe_network/Network in pipe_networks)
for(var/obj/machinery/atmospherics/AT in Network.normal_members)
if(!(AT in L))
continue
if(!AT.maptext)
AT.maptext = "<font color='white'>[copytext("\ref[Network]",8,12)]</font>"
else
world << "DUPLICATE: <A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[AT.x];Y=[AT.y];Z=[AT.z]'>[AT.name]</a> net#<A HREF='?_src_=vars;Vars=\ref[Network]'>[copytext("\ref[Network]",8,12)]</A>)"
for(var/datum/pipeline/PL in Network.line_members)
for(var/obj/machinery/atmospherics/AT in PL.members)
if(!(AT in L))
continue
if(!AT.maptext)
AT.maptext = "<font color='green'>[copytext("\ref[Network]",8,12)]</font>"
else
world << "DUPLICATE: <A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[AT.x];Y=[AT.y];Z=[AT.z]'>[AT.name]</a> net#<A HREF='?_src_=vars;Vars=\ref[Network]'>[copytext("\ref[Network]",8,12)]</A>)"
for(var/obj/machinery/atmospherics/ATE in PL.edges)
if(!(ATE in L))
continue
if(!ATE.maptext)
ATE.maptext = "<font color='red'>[copytext("\ref[Network]",8,12)]</font>"
else
world << "DUPLICATE: <A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[ATE.x];Y=[ATE.y];Z=[ATE.z]'>[ATE.name]</a> net#<A HREF='?_src_=vars;Vars=\ref[Network]'>[copytext("\ref[Network]",8,12)]</A>)"
/client/verb/follow_pipenet(var/netref as null|anything in get_refs(pipe_networks))
var/datum/pipe_network/Network = locate(netref)
if(!Network)
src << "Unable to locate [netref]"
return
for(var/obj/machinery/atmospherics/AT in world)
if(AT)
animate(AT, alpha = 255, time = 0)
for(var/obj/machinery/atmospherics/AT in Network.normal_members)
if(AT)
animate(AT, alpha = 0, time = 1, loop = -1)
animate(alpha = 255, time = 1)
for(var/datum/pipeline/PL in Network.line_members)
for(var/obj/machinery/atmospherics/AT in PL.members)
if(AT)
animate(AT, alpha = 0, time = 1, loop = -1)
animate(alpha = 255, time = 1)
/proc/get_refs(var/list/L)
. = list()
for(var/everything in L)
. += "\ref[everything]"
code/WorkInProgress/carn/debug_powernets.dm
+5 -6
View File
@@ -1,14 +1,13 @@
/*
client/verb/powernets_debug()
/client/verb/powernets_debug()
if(!holder) return
var/ref_holder = "\ref[holder]"
for(var/i=1,i<=powernets.len,i++)
src << "<a href='?[ref_holder];adminplayervars=\ref[powernets[i]]'>[copytext("\ref[powernets[i]]",8,12)]</A>"
// src << "<a href='?\ref[holder];adminplayervars=\ref[powernets[i]]'>[copytext("\ref[powernets[i]]",8,12)]</A>"
src << "<A HREF='?_src_=vars;Vars=\ref[powernets[i]]'>[copytext("\ref[powernets[i]]",8,12)]</A>"
client/verb/powernet_overlays()
/client/verb/powernet_overlays()
for(var/obj/structure/cable/C in cable_list)
C.maptext = "<font color='white'>[copytext("\ref[C.powernet]",8,12)]</font>"
for(var/obj/machinery/power/M in machines)
M.maptext = "<font color='white'>[copytext("\ref[M.powernet]",8,12)]</font>"
*/
code/WorkInProgress/explosion_particles.dm
+2 -2
View File
@@ -9,7 +9,7 @@
/obj/effect/expl_particles/New()
..()
spawn (15)
del(src)
qdel(src)
return
/obj/effect/expl_particles/Move()
@@ -49,7 +49,7 @@
/obj/effect/explosion/New()
..()
spawn (10)
del(src)
qdel(src)
return
/datum/effect/system/explosion