From 9f1d18dbdf059d3f19800bfdae6d9892fecdcaf9 Mon Sep 17 00:00:00 2001
From: Leland Kemble <70413276+lelandkemble@users.noreply.github.com>
Date: Tue, 18 Nov 2025 23:10:58 -0500
Subject: [PATCH] Prevents you from putting yourself in the DNA vault multiple
 times (#93905)

## About The Pull Request

You can't put more than one of the same dna in the vault, because the
probe checks when it scans you that your dna isn't in the probe's
storage or the vault's storage. But it doesn't check other probes, so
multiple probes can have the same dna, and can all upload the same dna
to the vault for duplicate DNA.

This PR adds a check when you upload to a vault that throws out dna
already in the vault before it's counted.

## Why It's Good For The Game

Duplicate DNA is clearly not intentional

## Changelog
:cl:

fix: You can no longer duplicate DNA for the DNA vault objective by
scanning yourself on several probes at once.

/:cl:
---
 code/game/objects/items/dna_probe.dm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/code/game/objects/items/dna_probe.dm b/code/game/objects/items/dna_probe.dm
index 9e3be2dce40..1f7307a8d75 100644
--- a/code/game/objects/items/dna_probe.dm
+++ b/code/game/objects/items/dna_probe.dm
@@ -54,6 +54,9 @@
 
 /obj/item/dna_probe/proc/try_upload_dna(obj/machinery/dna_vault/target, mob/user)
 	var/uploaded = 0
+	stored_dna_plants -= target.plant_dna
+	stored_dna_human -= target.human_dna
+	stored_dna_animal -= target.animal_dna
 	var/plant_dna_length = length(stored_dna_plants)
 	var/human_dna_length = length(stored_dna_human)
 	var/animal_dna_length = length(stored_dna_animal)