cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-20 04:26:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Radiation storm event fixes/improvements (#3905)

Browse Source 
## About The Pull Request

Fixes and tweaks to the radiation storm event.
- Actually enables/revokes emergency maintenance access like the
announcement says
- Removes the part of the announcement telling people to go to medbay at
the START of the radstorm
- Adjusts the announcement text to match the audio
- Fixes a check in minimum_security_level to ignore if emergency access
is already enabled
- Updated our alert proc with a new arg added by TG
- The weather alert sound plays to people on the impacted Z level,
making you aware the weather event started
- Deletes a duplicate radiation.ogg that exists for some reason

## Proof Of Testing

<details>
<summary>Screenshots/Videos</summary>

Shorter event announcement (No more 'please go to medbay')


https://github.com/user-attachments/assets/552e4eeb-a09e-4467-b69c-f10add7ecdb1

</details>

## Changelog

🆑 LT3
fix: Radiation storm event actually enables maintenance access
qol: Improved feedback and notifications for the radiation storm event
/🆑
This commit is contained in:
LT3
2025-05-26 15:33:38 -07:00
committed by GitHub
parent 77f91e43c9
commit a091c5e86a
9 changed files with 47 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/security_levels/keycard_authentication.dm
+6 -4
View File
@@ -207,7 +207,7 @@ MAPPING_DIRECTIONAL_HELPERS(/obj/machinery/keycard_auth/wall_mounted, 26)
find_and_hang_on_wall()
GLOBAL_VAR_INIT(emergency_access, FALSE)
/proc/make_maint_all_access()
/proc/make_maint_all_access(silent = FALSE) // BUBBER EDIT CHANGE - Silent Emergency Access
for(var/area/station/maintenance/area in GLOB.areas)
for (var/list/zlevel_turfs as anything in area.get_zlevel_turf_lists())
for(var/turf/area_turf as anything in zlevel_turfs)
@@ -215,11 +215,12 @@ GLOBAL_VAR_INIT(emergency_access, FALSE)
airlock.emergency = TRUE
airlock.update_icon(ALL, 0)
minor_announce("Access restrictions on maintenance and external airlocks have been lifted.", "Attention! Station-wide emergency declared!",1)
if(!silent) // BUBBER EDIT ADDITION - Silent Emergency Access
minor_announce("Access restrictions on maintenance and external airlocks have been lifted.", "Attention! Station-wide emergency declared!",1)
GLOB.emergency_access = TRUE
SSblackbox.record_feedback("nested tally", "keycard_auths", 1, list("emergency maintenance access", "enabled"))
/proc/revoke_maint_all_access()
/proc/revoke_maint_all_access(silent = FALSE) // BUBBER EDIT CHANGE - Silent Emergency Access
for(var/area/station/maintenance/area in GLOB.areas)
for (var/list/zlevel_turfs as anything in area.get_zlevel_turf_lists())
for(var/turf/area_turf as anything in zlevel_turfs)
@@ -227,7 +228,8 @@ GLOBAL_VAR_INIT(emergency_access, FALSE)
airlock.emergency = FALSE
airlock.update_icon(ALL, 0)
minor_announce("Access restrictions in maintenance areas have been restored.", "Attention! Station-wide emergency rescinded:")
if(!silent) // BUBBER EDIT ADDITION - Silent Emergency Access
minor_announce("Access restrictions in maintenance areas have been restored.", "Attention! Station-wide emergency rescinded:")
GLOB.emergency_access = FALSE
SSblackbox.record_feedback("nested tally", "keycard_auths", 1, list("emergency maintenance access", "disabled"))