cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-23 13:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fix hacker alias name preference not working (#28670)

Browse Source 
* Fix hacker alias name preference not working (#84695)

## About The Pull Request

So recently bitrunner avatars were made to use stereotypical gamertag
names, which introduced a new preference for 'hacker alias'.
This, however, didn't seem to actually work, and would always select a
random gamertag.

Looking into it, this seemed to be because it uses `old_body.client`:

https://github.com/tgstation/tgstation/blob/bd14e92d04f3dc4fd7aa06a9c49b04ec05bcc172/code/modules/bitrunning/components/avatar_connection.dm#L63-L64
Which at this point in the code would return `null`.
Making it use `avatar.client` instead seems to fix our issue.
## Why It's Good For The Game

Fixes hacker alias name preference not working.
## Changelog
🆑
fix: Fixes hacker alias name preference not working.
/🆑

* Fix hacker alias name preference not working

---------

Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-07-06 23:18:48 -04:00
committed by GitHub
co-authored by _0Steven
parent a995bf5284
commit a12c824f09
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/bitrunning/components/avatar_connection.dm
+1 -1
View File
@@ -60,7 +60,7 @@
var/datum/action/avatar_domain_info/action = new(help_datum)
action.Grant(avatar)
var/client/our_client = old_body.client
var/client/our_client = avatar.client
var/alias = our_client?.prefs?.read_preference(/datum/preference/name/hacker_alias) || pick(GLOB.hacker_aliases)
if(alias && avatar.real_name != alias)