mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-26 06:29:23 +01:00
Refactor, improve, and rename canUseTopic to be can_perform_action (#73434)
This builds on what #69790 did and improved the code even further. Notable things: - `Topic()` is a deprecated proc in our codebase (replaced with Javascript tgui) so it makes sense to rename `canUseTopic` to `can_perform_action` which is more straightforward in what it does. - Positional and named arguments have been converted into a easier to use `action_bitflag` - The bitflags adds some new checks you can use like: `NEED_GRAVITY | NEED_LITERACY | NEED_LIGHT` when you want to perform an action. - Redundant, duplicate, or dead code has been removed. - Fixes several runtimes where `canUseTopic` was being called without a proper target (IV drips, gibber, food processor) - Better documentation for the proc and bitflags with examples
This commit is contained in:
@@ -151,7 +151,7 @@ at the cost of risking a vicious bite.**/
|
||||
switch(altar_result)
|
||||
if("Change Color")
|
||||
var/chosen_color = input(user, "", "Choose Color", pants_color) as color|null
|
||||
if(!isnull(chosen_color) && user.canUseTopic(src, be_close = TRUE))
|
||||
if(!isnull(chosen_color) && user.can_perform_action(src))
|
||||
pants_color = chosen_color
|
||||
if("Create Artefact")
|
||||
if(!COOLDOWN_FINISHED(src, use_cooldown) || status != ALTAR_INACTIVE)
|
||||
|
||||
Reference in New Issue
Block a user