From a490e7afd458e7747e41f0d904a11355129da4ff Mon Sep 17 00:00:00 2001 From: FlufflesTheDog Date: Sat, 19 Apr 2025 23:21:50 -0700 Subject: [PATCH] Fix passive modsuit modules (#90719) ## About The Pull Request Fixes https://github.com/NovaSector/NovaSector/issues/5311 Fix some unreachable code and some broken invariants ## Why It's Good For The Game bug bad modsuit good ## Changelog :cl: fix: Passive modsuit modules (radiation protection, welding protection, etc) should work reliably again. /:cl: --- code/modules/mod/mod_activation.dm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/code/modules/mod/mod_activation.dm b/code/modules/mod/mod_activation.dm index 12de6ac26d7..cfcc838ee09 100644 --- a/code/modules/mod/mod_activation.dm +++ b/code/modules/mod/mod_activation.dm @@ -283,7 +283,7 @@ for(var/obj/item/mod/module/module as anything in modules) if(module.part_activated || !module.has_required_parts(mod_parts, need_active = TRUE)) continue - module.on_part_activation() + module.on_part_activation() module.part_activated = TRUE else for(var/obj/item/mod/module/module as anything in modules) @@ -304,11 +304,13 @@ for(var/obj/item/mod/module/module as anything in modules) if(!module.part_activated && module.has_required_parts(mod_parts, need_active = TRUE)) module.on_part_activation() + module.part_activated = TRUE else for(var/obj/item/mod/module/module as anything in modules) if(!module.part_activated) continue module.on_part_deactivation() + module.part_activated = FALSE update_charge_alert() update_appearance(UPDATE_ICON_STATE) wearer.update_clothing()