From a4b864b10e2565d33ff8ec1571b4d78ae7a5df4f Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Fri, 23 Oct 2020 00:02:31 +0200 Subject: [PATCH] [MIRROR] Fixes shapeshift transformation runtime (#1427) * Fixes shapeshift transformation runtime (#54484) Code improvement PR that changed this to use lazylists forgot to then remove the .Remove() part after. As a result, this will runtime either when mob_spell_list is null, or when mob_spell_list only contains src as LAZYREMOVE nulls the list for Remove() to runtime afterwards. Fixes all transformations where the above was the case, very specifically Vampires changing to bats and back. * Fixes shapeshift transformation runtime Co-authored-by: Timberpoes --- code/modules/spells/spell_types/shapeshift.dm | 1 - 1 file changed, 1 deletion(-) diff --git a/code/modules/spells/spell_types/shapeshift.dm b/code/modules/spells/spell_types/shapeshift.dm index 3fdde710f8d..643ff543f74 100644 --- a/code/modules/spells/spell_types/shapeshift.dm +++ b/code/modules/spells/spell_types/shapeshift.dm @@ -27,7 +27,6 @@ /obj/effect/proc_holder/spell/targeted/shapeshift/cast(list/targets,mob/user = usr) if(src in user.mob_spell_list) LAZYREMOVE(user.mob_spell_list, src) - user.mob_spell_list.Remove(src) user.mind.AddSpell(src) if(user.buckled) user.buckled.unbuckle_mob(src,force=TRUE)