[MIRROR] Renames vars on pdas and removes ntnet_relays glob [MDB IGNORE] (#24960)

* Renames vars on pdas and removes ntnet_relays glob (#79595)

## About The Pull Request

- replaces the ntnet_relays global list with ``get_machines_by_type``
- renames ``transfer_access`` var on PDA to ``download_access`` &
``required_access`` to ``run_access`` to better describe what they do,
because on more than one ocassion I've confused myself with the two
terms and ended up doing something unintentional (see:
https://github.com/tgstation/tgstation/pull/74269)

## Why It's Good For The Game

Kills a useless global list and makes pda code a little less confusing.

## Changelog

Nothing player-facing.

* Renames vars on pdas and removes ntnet_relays glob

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-11-13 12:13:28 +01:00
committed by GitHub
parent 5c239e10ef
commit a5818dd539
21 changed files with 66 additions and 73 deletions
@@ -8,8 +8,8 @@
size = 10
tgui_id = "NtosTechweb"
program_icon = "atom"
required_access = list(ACCESS_COMMAND, ACCESS_RESEARCH)
transfer_access = list(ACCESS_RESEARCH)
run_access = list(ACCESS_COMMAND, ACCESS_RESEARCH)
download_access = list(ACCESS_RESEARCH)
/// Reference to global science techweb
var/datum/techweb/stored_research
/// Access needed to lock/unlock the console