From a6d1a3a8adffb0d4104e5655b35fab8d4a0ae348 Mon Sep 17 00:00:00 2001
From: SkyratBot <59378654+SkyratBot@users.noreply.github.com>
Date: Fri, 25 Aug 2023 04:19:41 +0200
Subject: [PATCH] [MIRROR] Fixes hitting RCD effects when they're done [MDB
 IGNORE] (#23311)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Fixes hitting RCD effects when they're done (#77896)

## About The Pull Request

https://github.com/tgstation/tgstation/pull/77641 made it so that RCD
effects can be hit while they're constructing to stop their
construction. however, the construction effect itself lingers a bit
after things are done constructing, allowing it to eat up clicks. this
fixes it by removing the flag when it's done constructing.

## Why It's Good For The Game

fix good 👯 👯‍♂️ 👯‍♀️ 🎉 🏖️ 🐝

## Changelog

:cl:
fix: You should no longer attack RCD effects when they're done
constructing.
/:cl:

* Fixes hitting RCD effects when they're done

---------

Co-authored-by: iwishforducks <65363339+iwishforducks@users.noreply.github.com>
Co-authored-by: Pinta <68373373+softcerv@users.noreply.github.com>
---
 code/game/objects/effects/temporary_visuals/miscellaneous.dm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/code/game/objects/effects/temporary_visuals/miscellaneous.dm b/code/game/objects/effects/temporary_visuals/miscellaneous.dm
index b1d58cf748e..3098d8c7125 100644
--- a/code/game/objects/effects/temporary_visuals/miscellaneous.dm
+++ b/code/game/objects/effects/temporary_visuals/miscellaneous.dm
@@ -547,6 +547,8 @@
 	if (status == RCD_DECONSTRUCT)
 		qdel(src)
 	else
+		mouse_opacity = MOUSE_OPACITY_TRANSPARENT
+		obj_flags &= ~CAN_BE_HIT
 		icon_state = "rcd_end"
 		addtimer(CALLBACK(src, PROC_REF(end)), 15)