From a8a2af902b27de5012912d7641b18b49ca098c2d Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Wed, 1 Sep 2021 17:50:32 +0200 Subject: [PATCH] [MIRROR] Adds a stack trace for objs with <=0 integ taking damage (#7909) * Adds a stack trace for objs with <=0 integ taking damage (#61079) Adds a stack_trace to <=0 integ objs taking damage so instances of people relying on this early return prior can be identified * Adds a stack trace for objs with <=0 integ taking damage Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> --- code/game/objects/obj_defense.dm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/code/game/objects/obj_defense.dm b/code/game/objects/obj_defense.dm index 20029e306e7..8297d1de762 100644 --- a/code/game/objects/obj_defense.dm +++ b/code/game/objects/obj_defense.dm @@ -4,9 +4,12 @@ if(QDELETED(src)) stack_trace("[src] taking damage after deletion") return + if(obj_integrity <= 0) + stack_trace("[src] taking damage while having <= 0 integrity") + return if(sound_effect) play_attack_sound(damage_amount, damage_type, damage_flag) - if((resistance_flags & INDESTRUCTIBLE) || obj_integrity <= 0) + if(resistance_flags & INDESTRUCTIBLE) return damage_amount = run_obj_armor(damage_amount, damage_type, damage_flag, attack_dir, armour_penetration) if(damage_amount < DAMAGE_PRECISION)