cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-25 08:34:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fix moon rocks, saturnx globs, and blastoff ampoules recipe reagents disappearing into the ether (#27842)

Browse Source 
* Fix moon rocks, saturnx globs, and blastoff ampoules recipe reagents disappearing into the ether (#83382)

## About The Pull Request

When making moon rocks, saturnx, or blastoff I'd notice it'd sometimes
use more reagents than expected. Testing around a bit, it'd sometimes
just eat the reagents without making anything.
Looking into it, this seemed to be due to it trying to react and eating
the reagents to do so before actually reaching the minimum reagent
count.
Adding the `REACTION_INSTANT` flag to these reactions fixes this.
## Why It's Good For The Game

Fixes reagents disappearing without doing anything.
## Changelog
🆑
fix: Mixing the reagents for moon rocks, bLaSToFF ampoules, or SaturnX
globs in amounts less than the minimum for the recipe no longer eats the
reagents without doing anything.
/🆑

* Fix moon rocks, saturnx globs, and blastoff ampoules recipe reagents disappearing into the ether

---------

Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-05-25 20:58:50 +02:00
committed by GitHub
parent 808edc6900
commit a999e8df87
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
code/modules/reagents/chemistry/recipes/drugs.dm
View File

@@ -122,9 +122,10 @@
reaction_tags = REACTION_TAG_EASY | REACTION_TAG_DRUG | REACTION_TAG_ORGAN | REACTION_TAG_DAMAGING
//These drug item reactions should probably be converted to fermichem in the future.
/datum/chemical_reaction/moon_rock //botany is real easy so it requires a lot of kronkus_extract, make it cheaper if it doesnt get amde.
/datum/chemical_reaction/moon_rock //botany is real easy so it requires a lot of kronkus_extract, make it cheaper if it doesnt get made.
required_reagents = list(/datum/reagent/kronkus_extract = 15, /datum/reagent/fuel = 10, /datum/reagent/ammonia = 5)
mob_react = FALSE
reaction_flags = REACTION_INSTANT
reaction_tags = REACTION_TAG_EASY | REACTION_TAG_DRUG | REACTION_TAG_ORGAN | REACTION_TAG_DAMAGING
/datum/chemical_reaction/moon_rock/on_reaction(datum/reagents/holder, datum/equilibrium/reaction, created_volume)
@@ -137,6 +138,7 @@
/datum/chemical_reaction/blastoff_ampoule
required_reagents = list(/datum/reagent/silver = 10, /datum/reagent/toxin/cyanide = 10, /datum/reagent/lye = 5)
mob_react = FALSE
reaction_flags = REACTION_INSTANT
reaction_tags = REACTION_TAG_EASY | REACTION_TAG_DRUG | REACTION_TAG_ORGAN | REACTION_TAG_DAMAGING
/datum/chemical_reaction/blastoff_ampoule/on_reaction(datum/reagents/holder, datum/equilibrium/reaction, created_volume)
@@ -149,6 +151,7 @@
/datum/chemical_reaction/saturnx_glob
required_reagents = list(/datum/reagent/lead = 5, /datum/reagent/consumable/nothing = 5, /datum/reagent/drug/maint/tar = 10)
mob_react = FALSE
reaction_flags = REACTION_INSTANT
reaction_tags = REACTION_TAG_EASY | REACTION_TAG_DRUG | REACTION_TAG_ORGAN | REACTION_TAG_DAMAGING
/datum/chemical_reaction/saturnx_glob/on_reaction(datum/reagents/holder, datum/equilibrium/reaction, created_volume)