mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
Fixes DB admin ranks being 16 bits wide instead of 24 (#89348)
## About The Pull Request
smallint is 2 bytes, increased it to mediumint which is 3 bytes
Issue has not cropped up yet as theres only 15 flags right now, but
there can be up to 24 in dm side soooo
```
DEBUG-SQL: MySqlError { ERROR 1264 (22003): Out of range value for column 'flags' at row 1 } | Query used: INSERT INTO admin_ranks
- (rank, flags, exclude_flags, can_edit_flags)
```
my mysql is broken so I havent tested the update query but how bad can
it be :clueless:
## Changelog
🆑
server: An issue where more than 16 admin flags could not exist in the
DB has been corrected
/🆑
---------
Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
This commit is contained in:
@@ -5,15 +5,25 @@ Make sure to also update `DB_MAJOR_VERSION` and `DB_MINOR_VERSION`, which can be
|
|||||||
The latest database version is 5.28; The query to update the schema revision table is:
|
The latest database version is 5.28; The query to update the schema revision table is:
|
||||||
|
|
||||||
```sql
|
```sql
|
||||||
INSERT INTO `schema_revision` (`major`, `minor`) VALUES (5, 28);
|
INSERT INTO `schema_revision` (`major`, `minor`) VALUES (5, 29);
|
||||||
```
|
```
|
||||||
or
|
or
|
||||||
|
|
||||||
```sql
|
```sql
|
||||||
INSERT INTO `SS13_schema_revision` (`major`, `minor`) VALUES (5, 28);
|
INSERT INTO `SS13_schema_revision` (`major`, `minor`) VALUES (5, 29);
|
||||||
```
|
```
|
||||||
In any query remember to add a prefix to the table names if you use one.
|
In any query remember to add a prefix to the table names if you use one.
|
||||||
-----------------------------------------------------
|
-----------------------------------------------------
|
||||||
|
Version 5.29, 4 February 2024, by Tiviplus
|
||||||
|
Fixed admin rank table flags being capped at 16 in the DB instead of 24 (byond max)
|
||||||
|
|
||||||
|
```sql
|
||||||
|
ALTER TABLE `admin_ranks`
|
||||||
|
MODIFY COLUMN `flags` mediumint(5) unsigned NOT NULL,
|
||||||
|
MODIFY COLUMN `exclude_flags` mediumint(5) unsigned NOT NULL,
|
||||||
|
MODIFY COLUMN `can_edit_flags` mediumint(5) unsigned NOT NULL;
|
||||||
|
```
|
||||||
|
-----------------------------------------------------
|
||||||
Version 5.28, 1 November 2024, by Ghommie
|
Version 5.28, 1 November 2024, by Ghommie
|
||||||
Added `fish_progress` as the first 'progress' subtype of 'datum/award/scores'
|
Added `fish_progress` as the first 'progress' subtype of 'datum/award/scores'
|
||||||
|
|
||||||
|
|||||||
@@ -53,9 +53,9 @@ DROP TABLE IF EXISTS `admin_ranks`;
|
|||||||
/*!40101 SET character_set_client = utf8 */;
|
/*!40101 SET character_set_client = utf8 */;
|
||||||
CREATE TABLE `admin_ranks` (
|
CREATE TABLE `admin_ranks` (
|
||||||
`rank` varchar(32) NOT NULL,
|
`rank` varchar(32) NOT NULL,
|
||||||
`flags` smallint(5) unsigned NOT NULL,
|
`flags` mediumint(5) unsigned NOT NULL,
|
||||||
`exclude_flags` smallint(5) unsigned NOT NULL,
|
`exclude_flags` mediumint(5) unsigned NOT NULL,
|
||||||
`can_edit_flags` smallint(5) unsigned NOT NULL,
|
`can_edit_flags` mediumint(5) unsigned NOT NULL,
|
||||||
PRIMARY KEY (`rank`)
|
PRIMARY KEY (`rank`)
|
||||||
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
|
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
|
||||||
/*!40101 SET character_set_client = @saved_cs_client */;
|
/*!40101 SET character_set_client = @saved_cs_client */;
|
||||||
|
|||||||
@@ -53,9 +53,9 @@ DROP TABLE IF EXISTS `SS13_admin_ranks`;
|
|||||||
/*!40101 SET character_set_client = utf8 */;
|
/*!40101 SET character_set_client = utf8 */;
|
||||||
CREATE TABLE `SS13_admin_ranks` (
|
CREATE TABLE `SS13_admin_ranks` (
|
||||||
`rank` varchar(32) NOT NULL,
|
`rank` varchar(32) NOT NULL,
|
||||||
`flags` smallint(5) unsigned NOT NULL,
|
`flags` mediumint(5) unsigned NOT NULL,
|
||||||
`exclude_flags` smallint(5) unsigned NOT NULL,
|
`exclude_flags` mediumint(5) unsigned NOT NULL,
|
||||||
`can_edit_flags` smallint(5) unsigned NOT NULL,
|
`can_edit_flags` mediumint(5) unsigned NOT NULL,
|
||||||
PRIMARY KEY (`rank`)
|
PRIMARY KEY (`rank`)
|
||||||
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
|
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci;
|
||||||
/*!40101 SET character_set_client = @saved_cs_client */;
|
/*!40101 SET character_set_client = @saved_cs_client */;
|
||||||
|
|||||||
@@ -20,7 +20,7 @@
|
|||||||
*
|
*
|
||||||
* make sure you add an update to the schema_version stable in the db changelog
|
* make sure you add an update to the schema_version stable in the db changelog
|
||||||
*/
|
*/
|
||||||
#define DB_MINOR_VERSION 28
|
#define DB_MINOR_VERSION 29
|
||||||
|
|
||||||
|
|
||||||
//! ## Timing subsystem
|
//! ## Timing subsystem
|
||||||
|
|||||||
Reference in New Issue
Block a user