[MIRROR] Cuts down on unnecessary non-TGUI stuff [MDB IGNORE] (#24896)

* Cuts down on unnecessary non-TGUI stuff (#79590)

## About The Pull Request

Removes INTERACT_MACHINE_SET_MACHINE on machines that don't use a
non-TGUI UI.
Removes set_machine from TGUI things that forgot to remove them
previously.
Decouples advanced camera consoles from UI procs since it doesn't
actually use one.

## Why It's Good For The Game

TGUI machines don't need to be using these procs and vars, and this
makes it more clear what does and doesn't use a TGUI menu from a glance.
I explain it a bit better
[here](https://hackmd.io/XLt5MoRvRxuhFbwtk4VAUA) if you're interested.

## Changelog

No player-facing changes.

* Cuts down on unnecessary non-TGUI stuff

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-11-09 18:54:14 -05:00
committed by GitHub
co-authored by John Willard
parent bbd547ec95
commit aa3e795e36
25 changed files with 29 additions and 46 deletions
@@ -70,6 +70,7 @@
icon = 'icons/obj/machines/mining_machines.dmi'
icon_state = "console"
density = TRUE
interaction_flags_machine = INTERACT_MACHINE_WIRES_IF_OPEN|INTERACT_MACHINE_ALLOW_SILICON|INTERACT_MACHINE_OPEN_SILICON|INTERACT_MACHINE_SET_MACHINE
/// Connected ore processing machine.
var/obj/machinery/mineral/processing_unit/processing_machine
+1
View File
@@ -8,6 +8,7 @@ GLOBAL_LIST_EMPTY(silo_access_logs)
icon_state = "silo"
density = TRUE
circuit = /obj/item/circuitboard/machine/ore_silo
interaction_flags_machine = INTERACT_MACHINE_WIRES_IF_OPEN|INTERACT_MACHINE_ALLOW_SILICON|INTERACT_MACHINE_OPEN_SILICON|INTERACT_MACHINE_SET_MACHINE
/// The machine UI's page of logs showing ore history.
var/log_page = 1
-2
View File
@@ -83,8 +83,6 @@
return
if(!Adjacent(usr))
return
add_fingerprint(usr)
usr.set_machine(src)
switch(action)
if("removeall")
dump_box_contents()