cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-20 12:35:33 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Corrects record_feedback()'s copy/paste comment [MDB IGNORE] (#20777)

Browse Source 
* Corrects record_feedback()'s copy/paste comment (#74962)

## About The Pull Request

Corrects `record_feedback()`'s copy/paste comment.

## Pointless history

Originally being added in e2a8a5e, it kept its name and args for quite a
few years, that was until #32188 which had it renamed to
`record_feedback` and its args pretty much doubled. In between these
times the known copy/paste comment was already around, but that wasn't
updated, until now apparently.

* Corrects record_feedback()'s copy/paste comment

---------

Co-authored-by: Zandario <zandarioh@gmail.com>
This commit is contained in:
SkyratBot
2023-04-26 06:38:37 +01:00
committed by GitHub
parent 080f929112
commit ae475697c0
39 changed files with 144 additions and 147 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/buildmode/submodes/proccall.dm
+3 -3
View File
@@ -27,7 +27,7 @@
if(!proc_name || !proc_args)
tgui_alert(target_client, "Undefined ProcCall or arguments.")
return
if(!hascall(object, proc_name))
to_chat(target_client, span_warning("Error: callproc_datum(): type [object.type] has no proc named [proc_name]."), confidential = TRUE)
return
@@ -36,12 +36,12 @@
to_chat(target_client, span_warning("Error: callproc_datum(): owner of proc no longer exists."), confidential = TRUE)
return
var/msg = "[key_name(target_client)] called [object]'s [proc_name]() with [proc_args.len ? "the arguments [list2params(proc_args)]":"no arguments"]."
log_admin(msg)
message_admins(msg)
admin_ticket_log(object, msg)
SSblackbox.record_feedback("tally", "admin_verb", 1, "Atom ProcCall") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
SSblackbox.record_feedback("tally", "admin_verb", 1, "Atom ProcCall") // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!
var/returnval = WrapAdminProcCall(object, proc_name, proc_args) // Pass the lst as an argument list to the proc
. = target_client.get_callproc_returnval(returnval, proc_name)
code/modules/buildmode/submodes/tweakcomps.dm
+3 -5
View File
@@ -10,12 +10,12 @@
***********************************************************"))
/datum/buildmode_mode/tweakcomps/change_settings(client/target_client)
var/rating_to_choose = input(target_client, "Enter number of rating", "Number", "1")
var/rating_to_choose = input(target_client, "Enter number of rating", "Number", "1")
rating_to_choose = text2num(rating_to_choose)
if(!isnum(rating_to_choose))
tgui_alert(target_client, "Input a number.")
return
rating = rating_to_choose
/datum/buildmode_mode/tweakcomps/handle_click(client/target_client, params, obj/machinery/object)
@@ -31,6 +31,4 @@
P.rating = rating
object.RefreshParts()
SSblackbox.record_feedback("nested tally", "admin_toggle", 1, list("Machine Upgrade", "[rating]")) //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
SSblackbox.record_feedback("nested tally", "admin_toggle", 1, list("Machine Upgrade", "[rating]")) // If you are copy-pasting this, ensure the 4th parameter is unique to the new proc!