From ae91dda7b87c654045bae57cf1ed039b07bf137e Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Wed, 14 Oct 2020 12:31:55 +0200 Subject: [PATCH] [MIRROR] Fix improper null coalescence with has_antag_datum (#1298) * Fix improper null coalescence with has_antag_datum (#54382) Fixes an incorrect correction of has_antag_datum to use ?.. This does not work since has_antag_datum returns 0 or an object, meaning has_antag_datum()?.property is essentially 0.property. (Lemon's note, it was causing names to not show in radio chat) * Fix improper null coalescence with has_antag_datum Co-authored-by: Jared-Fogle <35135081+Jared-Fogle@users.noreply.github.com> --- code/datums/mind.dm | 1 - 1 file changed, 1 deletion(-) diff --git a/code/datums/mind.dm b/code/datums/mind.dm index d11fe7fdaf8..155869dc2ea 100644 --- a/code/datums/mind.dm +++ b/code/datums/mind.dm @@ -278,7 +278,6 @@ /datum/mind/proc/has_antag_datum(datum_type, check_subtypes = TRUE) if(!datum_type) return - . = FALSE for(var/a in antag_datums) var/datum/antagonist/A = a if(check_subtypes && istype(A, datum_type))