cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-29 19:11:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Combined soundadd/sounddel and imageadd/imagedel (#74865)

Browse Source 
## About The Pull Request
Combines
```
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
```
into "sound," and
```
imageadd: added some icons and images
imagedel: deleted some icons and images
```
into "image" in the changelog. 

I don't think we need to have both; `sound` and `image` can represent
any kind of change to their respective medium.

---------

Co-authored-by: tattle <article.disaster@gmail.com>
This commit is contained in:
tattle
2023-04-21 12:10:26 -07:00
committed by GitHub
parent c09eb15abf
commit aeed75d72f
3 changed files with 10 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@@ -20,10 +20,8 @@ del: Removed old things
qol: made something easier to use qol: made something easier to use
balance: rebalanced something balance: rebalanced something
fix: fixed a few things fix: fixed a few things
soundadd: added a new sound thingy sound: added/modified/removed audio or sound effects
sounddel: removed an old sound thingy image: added/modified/removed some icons or images
imageadd: added some icons and images
imagedel: deleted some icons and images
spellcheck: fixed a few typos spellcheck: fixed a few typos
code: changed some code code: changed some code
refactor: refactored some code refactor: refactored some code

20
tools/WebhookProcessor/github_webhook_processor.php
View File

@@ -705,17 +705,11 @@ function checkchangelog($payload) {
$tags[] = 'Quality of Life'; $tags[] = 'Quality of Life';
} }
break; break;
case 'soundadd': case 'sound':
if($item != 'added a new sound thingy') { if($item != 'added/modified/removed audio or sound effects') {
$tags[] = 'Sound'; $tags[] = 'Sound';
} }
break; break;
case 'sounddel':
if($item != 'removed an old sound thingy') {
$tags[] = 'Sound';
$tags[] = 'Removal';
}
break;
case 'add': case 'add':
case 'adds': case 'adds':
case 'rscadd': case 'rscadd':
@@ -730,17 +724,11 @@ function checkchangelog($payload) {
$tags[] = 'Removal'; $tags[] = 'Removal';
} }
break; break;
case 'imageadd': case 'image':
if($item != 'added some icons and images') { if($item != 'added/modified/removed some icons or images') {
$tags[] = 'Sprites'; $tags[] = 'Sprites';
} }
break; break;
case 'imagedel':
if($item != 'deleted some icons and images') {
$tags[] = 'Sprites';
$tags[] = 'Removal';
}
break;
case 'typo': case 'typo':
case 'spellcheck': case 'spellcheck':
if($item != 'fixed a few typos') { if($item != 'fixed a few typos') {

22
tools/pull_request_hooks/changelogConfig.js
View File

@@ -40,30 +40,16 @@ export const CHANGELOG_ENTRIES = [
], ],
[ [
["soundadd"], ["sound"],
{ {
placeholders: ["added a new sound thingy"], placeholders: ["added/modified/removed audio or sound effects"],
}, },
], ],
[ [
["sounddel"], ["image"],
{ {
placeholders: ["removed an old sound thingy"], placeholders: ["added/modified/removed some icons or images"],
},
],
[
["imageadd"],
{
placeholders: ["added some icons and images"],
},
],
[
["imagedel"],
{
placeholders: ["deleted some icons and images"],
}, },
], ],