From afdd88c717a923e40825aec190e58b379cc43883 Mon Sep 17 00:00:00 2001 From: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Date: Thu, 26 Jun 2025 20:59:41 -0700 Subject: [PATCH] Fixes an issue with ranks (#91848) ## About The Pull Request All these guard checks, layers and layers of protection, built from the ground to the outer firmament, and you fucking got the negation wrong. --- code/modules/admin/permissionedit.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/modules/admin/permissionedit.dm b/code/modules/admin/permissionedit.dm index b2605fea270..026a97ec520 100644 --- a/code/modules/admin/permissionedit.dm +++ b/code/modules/admin/permissionedit.dm @@ -509,7 +509,7 @@ ADMIN_VERB(edit_admin_permissions, R_PERMISSIONS, "Permissions Panel", "Edit adm if(!admin_rank) return for(var/datum/admin_rank/R in GLOB.admin_ranks) - if(R.name == admin_rank && (!(R.rights & usr.client.holder.can_edit_rights_flags()) == R.rights)) + if(R.name == admin_rank && ((R.rights & usr.client.holder.can_edit_rights_flags()) != R.rights)) to_chat(usr, "You don't have edit rights to all the rights this rank has, rank deletion not permitted.", confidential = TRUE) return if(!CONFIG_GET(flag/admin_legacy_system) && CONFIG_GET(flag/protect_legacy_ranks) && (admin_rank in GLOB.protected_ranks))