From b068c1e7c9fe540d56c3043802175d5e2ea84aaa Mon Sep 17 00:00:00 2001 From: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Date: Sat, 10 Jan 2026 13:24:12 -0500 Subject: [PATCH] Fixes job changing swapping paycheck dep (#94792) ## About The Pull Request Adding job access in the HoP's console (``add_trim_access_to_card`` proc) changes the paycheck department of EVERYONE of that job, because we assign all players via one job datum using ``SStype_occupations`` (through ``get_job_type``), so everyone's bank account stores the same job datum as everyone else of their job. To fix this, we are simply going to update the job of the bank account to the new one, rather than change the paycheck department. This will keep it in-sync with the current system while fixing the bug. ## Why It's Good For The Game WTAF. --- code/controllers/subsystem/networks/id_access.dm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/code/controllers/subsystem/networks/id_access.dm b/code/controllers/subsystem/networks/id_access.dm index 94793f31114..889c59fbf5b 100644 --- a/code/controllers/subsystem/networks/id_access.dm +++ b/code/controllers/subsystem/networks/id_access.dm @@ -508,7 +508,7 @@ SUBSYSTEM_DEF(id_access) id_card.add_wildcards(trim.wildcard_access, mode = TRY_ADD_ALL) if(istype(trim, /datum/id_trim/job)) var/datum/id_trim/job/job_trim = trim // Here is where we update a player's paycheck department for the purposes of discounts/paychecks. - id_card.registered_account.account_job.paycheck_department = job_trim.job.paycheck_department + id_card.registered_account.account_job = job_trim.job // Apply any currently active RETA grants to this card with updated trim access apply_active_reta_grants_to_card(id_card)