cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 00:29:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Fixes ntnet circuits [MDB IGNORE] (#20191)

Browse Source 
* Fixes ntnet circuits (#74338)

## About The Pull Request

I underestimated SEND_GLOBAL_SIGNAL and assumed it worked differently to
SEND_SIGNAL, as in I thought it would not be sending the source as the
first arg.
Because it does, it meant that the list of data was actually just ntnet
sending circuit. This fixes it and makes the args work properly.

I've shamelessly stolen the circuit in the screenshot of the issue to
test it in-game

![image](https://user-images.githubusercontent.com/53777086/228451819-4ffdb2e4-542e-46c1-9947-6266d8550f4a.png)

## Why It's Good For The Game

Closes https://github.com/tgstation/tgstation/issues/74327

## Changelog

🆑
fix: NtNet receive/send circuits should work now.
/🆑

* Fixes ntnet circuits

---------

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
This commit is contained in:
SkyratBot
2023-03-31 02:59:36 +01:00
committed by GitHub
co-authored by John Willard
parent f202b3cbb2
commit b1067980e0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/wiremod/components/ntnet/ntnet_send.dm
+1 -1
View File
@@ -35,4 +35,4 @@
/obj/item/circuit_component/ntnet_send/input_received(datum/port/input/port)
if(!find_functional_ntnet_relay())
return
SEND_GLOBAL_SIGNAL(COMSIG_GLOB_CIRCUIT_NTNET_DATA_SENT, src, list("data" = data_package.value, "enc_key" = enc_key.value, "port" = WEAKREF(data_package)))
SEND_GLOBAL_SIGNAL(COMSIG_GLOB_CIRCUIT_NTNET_DATA_SENT, list("data" = data_package.value, "enc_key" = enc_key.value, "port" = WEAKREF(data_package)))