cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-07-12 08:36:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enhanced delam/tram counter (#75699)

Browse Source 
## About The Pull Request

Gives a makeover to the delam and tram hit counters and adds some new
functionality.


![image](https://github.com/tgstation/tgstation/assets/83487515/cbbeb0df-d205-47ed-be6e-e49cea8c4f12)


![image](https://github.com/tgstation/tgstation/assets/83487515/e042d5e8-cb8b-4feb-b3f0-02365cd8fdbf)


![image](https://github.com/tgstation/tgstation/assets/83487515/c2831f7f-639d-40a8-a74f-d4894a4f67c6)


https://github.com/tgstation/tgstation/assets/83487515/871fb0fd-8b92-45c5-877b-c122a034608c

- The signs now remember your last 'best' score and show the crew if
they're trending in the right or wrong direction since the last
incident.
- Safety Moth PSA panel. In the future this will dynamically change
based on the current events, or function as a status display.
- Tram hit counters no longer waste processing every tram hit.
Previously each sign independently managed tracking, which meant that
deconstructing or constructing a sign would reset it to 0 and it would
become out of sync with the other signs.
- Can be repaired, EMP'd

## Why It's Good For The Game

Provide a little motivation to reach for that high score. The PSA
changing to for example, find a locker during a delam event.

## Changelog

🆑 LT3
image: Delam and tram flipsigns have been replaced with information
displays
fix: Tram hit count is centrally managed instead of independently on
each sign, so they won't get out of sync
/🆑
This commit is contained in:
lessthanthree
2023-06-23 11:29:34 -07:00
committed by GitHub
parent a3568da563
commit b3d040fb2f
15 changed files with 679 additions and 375 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/game/objects/structures/signs/signs_interactive.dm
-140
View File
@@ -1,5 +1,3 @@
#define COLLISION_HAZARD_THRESHOLD 11
/obj/structure/sign/clock
name = "wall clock"
desc = "It's your run-of-the-mill wall clock showing both the local Coalition Standard Time and the galactic Treaty Coordinated Time. Perfect for staring at instead of working."
@@ -26,141 +24,3 @@ MAPPING_DIRECTIONAL_HELPERS(/obj/structure/sign/calendar, 32)
. += span_info("Events:")
for(var/holidayname in GLOB.holidays)
. += span_info("[holidayname]")
/**
* List of delamination counter signs on the map.
* Required as persistence subsystem loads after the ones present at mapload, and to reset to 0 upon explosion.
*/
GLOBAL_LIST_EMPTY(map_delamination_counters)
/obj/structure/sign/delamination_counter
name = "delamination counter"
sign_change_name = "Flip Sign- Supermatter Delamination"
desc = "A pair of flip signs describe how long it's been since the last delamination incident."
icon_state = "days_since_explosion"
is_editable = TRUE
var/since_last = 0
MAPPING_DIRECTIONAL_HELPERS(/obj/structure/sign/delamination_counter, 32)
/obj/structure/sign/delamination_counter/Initialize(mapload)
. = ..()
GLOB.map_delamination_counters += src
if (!mapload)
update_count(SSpersistence.rounds_since_engine_exploded)
/obj/structure/sign/delamination_counter/Destroy()
GLOB.map_delamination_counters -= src
return ..()
/obj/structure/sign/delamination_counter/proc/update_count(new_count)
since_last = min(new_count, 99)
update_appearance()
/obj/structure/sign/delamination_counter/update_overlays()
. = ..()
var/ones = since_last % 10
var/mutable_appearance/ones_overlay = mutable_appearance('icons/obj/signs.dmi', "days_[ones]")
ones_overlay.pixel_w = 4
. += ones_overlay
var/tens = (since_last / 10) % 10
var/mutable_appearance/tens_overlay = mutable_appearance('icons/obj/signs.dmi', "days_[tens]")
tens_overlay.pixel_w = -5
. += tens_overlay
/obj/structure/sign/delamination_counter/examine(mob/user)
. = ..()
. += span_info("It has been [since_last] day\s since the last delamination event at a Nanotrasen facility.")
switch (since_last)
if (0)
. += span_info("In case you didn't notice.")
if(1)
. += span_info("Let's do better today.")
if(2 to 5)
. += span_info("There's room for improvement.")
if(6 to 10)
. += span_info("Good work!")
if(11 to INFINITY)
. += span_info("Incredible!")
/obj/structure/sign/collision_counter
name = "incident counter"
sign_change_name = "Indicator board- Tram incidents"
desc = "A display that indicates how many tram related incidents have occured today."
icon_state = "tram_hits"
is_editable = TRUE
var/hit_count = 0
var/tram_id = TRAM_LIFT_ID
/// Has the tram hit enough people it now flashes hazard lights?
var/hazard_flash = FALSE
/obj/structure/sign/collision_counter/Initialize(mapload)
..()
return INITIALIZE_HINT_LATELOAD
/obj/structure/sign/collision_counter/LateInitialize()
. = ..()
for(var/obj/structure/industrial_lift/tram/tram as anything in GLOB.lifts)
if(tram.lift_id != tram_id)
continue
RegisterSignal(tram, COMSIG_TRAM_COLLISION, PROC_REF(new_hit))
update_appearance()
/obj/structure/sign/collision_counter/Destroy()
return ..()
/obj/structure/sign/collision_counter/proc/new_hit(lift_master, collided_type)
SIGNAL_HANDLER
if(!ismob(collided_type))
return
var/mob/victim = collided_type // Real players only, no gaming high score
if(!victim.client)
return
hit_count++
if(hazard_flash)
update_appearance()
return
if(hit_count == COLLISION_HAZARD_THRESHOLD) // When we hit the threshold, enable flashing the lights
hazard_flash = TRUE
icon_state = "tram_hits_alert"
update_appearance()
return
update_appearance()
/obj/structure/sign/collision_counter/update_overlays()
. = ..()
var/ones = hit_count % 10
var/mutable_appearance/ones_overlay = mutable_appearance('icons/obj/signs.dmi', "hits_[ones]")
ones_overlay.pixel_w = 4
. += ones_overlay
var/tens = (hit_count / 10) % 10
var/mutable_appearance/tens_overlay = mutable_appearance('icons/obj/signs.dmi', "hits_[tens]")
tens_overlay.pixel_w = -5
. += tens_overlay
/obj/structure/sign/collision_counter/examine(mob/user)
. = ..()
. += span_info("The station has had [hit_count] incident\s this shift.")
switch (hit_count)
if(0)
. += span_info("Fantastic! Champions of safety.")
if(1)
. += span_info("Let's do better tomorrow.")
if(2 to 5)
. += span_info("There's room for improvement.")
if(6 to 10)
. += span_info("Good work! Nanotrasen's finest!")
if(11 to INFINITY)
. += span_info("Incredible! You're probably reading this from medbay.")
#undef COLLISION_HAZARD_THRESHOLD