From b430ab08ebbef5f53a154b1bb7d1ef53e4d99dae Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Tue, 9 Jul 2024 16:10:28 +0200 Subject: [PATCH] [MIRROR] Fix chem dispenser feedback (#28750) * Fix chem dispenser feedback (#84781) ## About The Pull Request When the beaker is full, chem dispenser thinks it should dispense 0 chemicals. If 0 chemicals should be dispensed, `cell.use` returns 0. The same value is returned when there isn't enough energy in the cell. Because of that, the dispenser was confused and gave off the wrong message. I added a check to fix that. Closes #84780. ## Why It's Good For The Game Bug bad ## Changelog :cl: fix: fixed dubious chem dispenser feedback when the beaker is full /:cl: * Fix chem dispenser feedback --------- Co-authored-by: zoomachina <97964454+zoomachina@users.noreply.github.com> --- code/modules/reagents/chemistry/machinery/chem_dispenser.dm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/code/modules/reagents/chemistry/machinery/chem_dispenser.dm b/code/modules/reagents/chemistry/machinery/chem_dispenser.dm index 06d9561744f..f7aadf04b8c 100644 --- a/code/modules/reagents/chemistry/machinery/chem_dispenser.dm +++ b/code/modules/reagents/chemistry/machinery/chem_dispenser.dm @@ -331,6 +331,9 @@ var/datum/reagents/holder = beaker.reagents var/to_dispense = max(0, min(amount, holder.maximum_volume - holder.total_volume)) + if(!to_dispense) + say("The container is full!") + return if(!cell.use(to_dispense * power_cost)) say("Not enough energy to complete operation!") return