cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-28 15:47:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Station Goals are now handled by SSstation instead of a global list (#26313)

Browse Source 
* Station Goals are now handled by SSstation instead of a global list (#81177)

## About The Pull Request

You can now get station goals in a slightly better way over using a
`locate() in` call on a global list.
The Meteor Satellite goal no longer stores a giant list of ALL OBJECTS
in view. And now correctly only counts turfs.
## Changelog
🆑
fix: Meteor Satellites no longer erroneously count every piece of paper
as a protected turf.
fix: As a result the station goal is slightly more difficult
/🆑

---------

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>

* Station Goals are now handled by SSstation instead of a global list

* Will it work? I do not know. But it compiles.

---------

Co-authored-by: Zephyr <12817816+ZephyrTFA@users.noreply.github.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@ users.noreply.github.com>
Co-authored-by: Useroth <37159550+Useroth@users.noreply.github.com>
This commit is contained in:
SkyratBot
2024-02-08 16:21:12 +01:00
committed by GitHub
co-authored by LemonInTheDark Zephyr Useroth
parent f74b368196
commit b485162a04
13 changed files with 95 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/topic.dm
-1
View File
@@ -1392,7 +1392,6 @@
return
G.report_message = description
message_admins("[key_name(usr)] created \"[G.name]\" station goal.")
GLOB.station_goals += G
modify_goals()
else if(href_list["change_lag_switch"])
code/modules/admin/verbs/debug.dm
+2 -2
View File
@@ -546,8 +546,8 @@
/datum/admins/proc/modify_goals()
var/dat = ""
for(var/datum/station_goal/S in GLOB.station_goals)
dat += "[S.name] - <a href='?src=[REF(S)];[HrefToken()];announce=1'>Announce</a> | <a href='?src=[REF(S)];[HrefToken()];remove=1'>Remove</a><br>"
for(var/datum/station_goal/goal as anything in SSstation.get_station_goals())
dat += "[goal.name] - <a href='?src=[REF(goal)];[HrefToken()];announce=1'>Announce</a> | <a href='?src=[REF(goal)];[HrefToken()];remove=1'>Remove</a><br>"
dat += "<br><a href='?src=[REF(src)];[HrefToken()];add_station_goal=1'>Add New Goal</a>"
usr << browse(dat, "window=goals;size=400x400")