From b4a478ebd0d99462f4d51fd10efc6560a5b95157 Mon Sep 17 00:00:00 2001
From: BurgerLUA <8602857+BurgerLUA@users.noreply.github.com>
Date: Fri, 31 May 2024 12:26:45 -0700
Subject: [PATCH] everything is fine (#1580)

## About The Pull Request

EVERYTHING IS FINE

## Why It's Good For The Game

AAAAAAA

## Proof Of Testing

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

## Changelog

:cl: BurgerBB
fix: Fixes maint loot being absurd.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

<!-- By opening a pull request. You have read and understood the
repository rules located on the main README.md on this project. -->

---------

Co-authored-by: Waterpig <49160555+Majkl-J@users.noreply.github.com>
---
 .../effects/spawners/random/maintenance.dm      | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/code/game/objects/effects/spawners/random/maintenance.dm b/code/game/objects/effects/spawners/random/maintenance.dm
index ea434cb416d..e4ce1ad36a5 100644
--- a/code/game/objects/effects/spawners/random/maintenance.dm
+++ b/code/game/objects/effects/spawners/random/maintenance.dm
@@ -19,7 +19,13 @@
 	loot = GLOB.maintenance_loot
 	//BUBBERSTATION CHANGE START: EMPTY MAINT LOOT TRAIT ONLY SPAWNS THE BEST LOOT
 	if(HAS_TRAIT(SSstation, STATION_TRAIT_EMPTY_MAINT))
-		loot = prob(80) ? GLOB.rarity_loot : GLOB.oddity_loot
+		if(prob(80))
+			loot = GLOB.uncommon_loot
+		else if(prob(80))
+			loot = GLOB.rarity_loot
+		else
+			loot = GLOB.oddity_loot
+
 	//BUBBERSTATION CHANGE END
 	return ..()
 
@@ -43,7 +49,14 @@
 		effective_lootcount = FLOOR(spawn_loot_count * 1.5, 1)
 
 	else if(HAS_TRAIT(SSstation, STATION_TRAIT_EMPTY_MAINT))
-		effective_lootcount = 1 //BUBBERSTATION CHANGE: ALWAYS JUST ONE.
+		//BUBBERSTATION CHANGE START: EMPTY MAINT LOOT TRAIT ONLY SPAWNS THE BEST LOOT. USUALLY
+		if(loot == GLOB.uncommon_loot )
+			effective_lootcount = min(effective_lootcount,3) //Maximum 3.
+		else if(effective_lootcount > 1)
+			effective_lootcount = 1
+		else
+			effective_lootcount = 0
+		//BUBBERSTATION CHANGE END: EMPTY MAINT LOOT TRAIT ONLY SPAWNS THE BEST LOOT. USUALLY
 
 	return effective_lootcount