cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-09 07:46:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removes spacemove crashes/impacts at high speed (#92284)

Browse Source 
## About The Pull Request

Something changed in spacemove loop code recently which caused infinite
recursions through throw code. This has been a rather bad mechanic
already, and I believe that it warrants removal alongside newtonian
zero-g physics in general - but for now lets just get rid of the part
that crashes the server.

## Why It's Good For The Game

We've pushed the speed limit to the point where you need to be firing a
SAW without a jetpack for a full minute to actually crash into
something, its a bad mechanic that doesn't bring much to the round
as-is.
This commit is contained in:
SmArtKar
2025-07-31 04:53:38 +02:00
committed by Roxy
parent 78908f40a3
commit b4b7aff894
2 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
code/__DEFINES/movement.dm
View File

@@ -144,9 +144,5 @@ GLOBAL_VAR_INIT(glide_size_multiplier, 1.0)
#define INERTIA_FORCE_SPACEMOVE_REDUCTION 0.75 NEWTONS
/// How much inertia we must have to not be able to instantly stop after having something to grab
#define INERTIA_FORCE_SPACEMOVE_GRAB 1.5 NEWTONS
/// How much inertia is required for the impacted object to be thrown at the wall
#define INERTIA_FORCE_THROW_FLOOR 10 NEWTONS
/// How much inertia is required past the floor to add 1 strength
#define INERTIA_FORCE_PER_THROW_FORCE 5 NEWTONS
// Results in maximum speed of 1 tile per tick, capped at about 2/3rds of maximum force
#define INERTIA_SPEED_COEF 0.375

2
code/datums/drift_handler.dm
View File

@@ -209,8 +209,6 @@
/datum/drift_handler/proc/attempt_halt(movement_dir, continuous_move, atom/backup)
if ((backup.density || !backup.CanPass(parent, get_dir(backup, parent))) && (get_dir(parent, backup) == movement_dir || parent.loc == backup.loc))
if (drift_force >= INERTIA_FORCE_THROW_FLOOR)
parent.throw_at(backup, 1, floor(1 + (drift_force - INERTIA_FORCE_THROW_FLOOR) / INERTIA_FORCE_PER_THROW_FORCE), spin = FALSE)
return FALSE
if (drift_force < INERTIA_FORCE_SPACEMOVE_GRAB || isnull(drifting_loop))