mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-06 06:52:39 +00:00
[MIRROR] More standardization for ghost notifications (READY) [MDB IGNORE] (#25104)
* More standardization for ghost notifications (READY) (#79596) ## About The Pull Request I'm still not satisfied with how ghost notifications work. This gives every notification with a source (99% of all notifications, in other words) a link to jump/orbit. Currently, notifications with "play" interactions would only get the interact link, so jumping to the source was pretty annoying. It removes posting the entire message in the alert tooltip, as some got pretty lengthy and it didn't seem to fit. To replace this, they will always use headers After:    NOTIFY_JUMP and NOTIFY_ORBIT have been merged, since the only difference seems to be whether it's a turf. The result shaves off some redundant lines of code, since most-every usage of notify_ghosts uses NOTIFY_ORBIT. ## Why It's Good For The Game More standardization for the ghost notification system. Adds a few alert headers that never had them. All in all, makes it easier for creators to throw alerts at ghosts ## Changelog 🆑 qol: Nearly every ghost alert should now feature a "VIEW" button, even those with click interaction. del: Ghost alerts no longer show the entire message in the tooltip, instead have been replaced with titles. /🆑 * More standardization for ghost notifications (READY) * Modular * Update outpost_of_cogs.dm --------- Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Giz <13398309+vinylspiders@users.noreply.github.com>
This commit is contained in:
@@ -380,7 +380,6 @@
|
||||
notify_ghosts(
|
||||
"[cultist] has begun scribing a Nar'Sie rune!",
|
||||
source = cultist,
|
||||
action = NOTIFY_ORBIT,
|
||||
header = "Maranax Infirmux!",
|
||||
notify_flags = NOTIFY_CATEGORY_NOFLASH,
|
||||
)
|
||||
|
||||
@@ -42,8 +42,7 @@
|
||||
notify_ghosts(
|
||||
"[parent] is now deadchat controllable!",
|
||||
source = parent,
|
||||
action = NOTIFY_ORBIT,
|
||||
header = "Something Interesting!",
|
||||
header = "Ghost Possession!",
|
||||
)
|
||||
if(!ismob(parent) && !SSpoints_of_interest.is_valid_poi(parent))
|
||||
SSpoints_of_interest.make_point_of_interest(parent)
|
||||
|
||||
@@ -113,7 +113,6 @@
|
||||
notify_ghosts(
|
||||
"[future_tram_victim] has fallen in the path of an oncoming tram!",
|
||||
source = future_tram_victim,
|
||||
action = NOTIFY_ORBIT,
|
||||
header = "Electrifying!",
|
||||
)
|
||||
do_sparks(4, FALSE, source)
|
||||
|
||||
@@ -26,8 +26,8 @@
|
||||
notify_ghosts(
|
||||
"[parent] is edible by ghosts!",
|
||||
source = parent,
|
||||
action = NOTIFY_ORBIT,
|
||||
header="Something Tasty!",
|
||||
header = "Something Tasty!",
|
||||
notify_flags = NOTIFY_CATEGORY_NOFLASH,
|
||||
)
|
||||
|
||||
/datum/component/ghost_edible/RegisterWithParent()
|
||||
|
||||
@@ -49,12 +49,11 @@
|
||||
|
||||
notify_ghosts(
|
||||
"[message]. An orbiter will be chosen in [DisplayTimeText(timeout)].\n",
|
||||
action = NOTIFY_ORBIT,
|
||||
enter_link = "<a href='?src=[REF(src)];ignore=[ignore_key]'>(Ignore)</a>",
|
||||
notify_flags = NOTIFY_CATEGORY_NOFLASH,
|
||||
header = "Volunteers requested",
|
||||
ignore_key = ignore_key,
|
||||
source = parent,
|
||||
header = "Volunteers requested",
|
||||
custom_link = " <a href='?src=[REF(src)];ignore=[ignore_key]'>(Ignore)</a>",
|
||||
ignore_key = ignore_key,
|
||||
notify_flags = NOTIFY_CATEGORY_NOFLASH,
|
||||
)
|
||||
|
||||
addtimer(CALLBACK(src, PROC_REF(end_poll)), timeout, TIMER_UNIQUE|TIMER_OVERRIDE|TIMER_STOPPABLE|TIMER_DELETE_ME)
|
||||
|
||||
@@ -306,7 +306,6 @@
|
||||
"[consumed_mob] has been dusted by [atom_source]!",
|
||||
source = atom_source,
|
||||
header = "Polytechnical Difficulties",
|
||||
notify_flags = NOTIFY_CATEGORY_DEFAULT,
|
||||
)
|
||||
consumed_mob.dust(force = TRUE)
|
||||
matter_increase += 100 * object_size
|
||||
|
||||
Reference in New Issue
Block a user