From b77cdda8a46c46fc551595021da448f07447dba1 Mon Sep 17 00:00:00 2001
From: Bloop <13398309+vinylspiders@users.noreply.github.com>
Date: Thu, 9 Oct 2025 21:59:59 -0400
Subject: [PATCH] Fix hard del/race condition in reflections (#93328)

## About The Pull Request

Tin, the proc that's managing references should remove the thing from
the list before calling qdel on it. Also, it should not be calling qdel
on something that's already being qdeleted (which could happen before if
`nuke_reflection()` was reached via the `COMSIG_QDELING` signal).

<img width="1675" height="480" alt="firefox_xIIRCIbgdU"
src="https://github.com/user-attachments/assets/246be9de-6ff0-46a5-bf5e-1d0895fd9f55"
/>


## Why It's Good For The Game

Less hard deletes

## Changelog

Not player facing/should get the hard deletes tag
---
 code/datums/components/reflection.dm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/datums/components/reflection.dm b/code/datums/components/reflection.dm
index 82ed1a24da2..d5d37b72dd2 100644
--- a/code/datums/components/reflection.dm
+++ b/code/datums/components/reflection.dm
@@ -148,9 +148,9 @@
 	SIGNAL_HANDLER
 
 	var/atom/movable/reflection = LAZYACCESS(reflected_movables, target)
-	if(reflection)
-		qdel(reflection)
 	LAZYREMOVE(reflected_movables, target)
+	if(!QDELETED(reflection))
+		qdel(reflection)
 	UnregisterSignal(target, check_reflect_signals)
 	UnregisterSignal(target, COMSIG_QDELETING)