From b816ef4b87767a51891d2dee2fe3211a2f675e5a Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Thu, 27 Aug 2020 22:10:52 +0200 Subject: [PATCH] [MIRROR] Adds a requirement to profile optimizations to contributing.md (#546) * Adds a requirement to profile optimizations to contributing.md (#53235) Co-authored-by: TiviPlus * Adds a requirement to profile optimizations to contributing.md Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com> --- .github/CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index a739e01b741..b925b070fa7 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -408,7 +408,7 @@ There is no strict process when it comes to merging pull requests. Pull requests * Make sure your pull request complies to the requirements outlined here -* You are going to be expected to document all your changes in the pull request. Failing to do so will mean delaying it as we will have to question why you made the change. On the other hand, you can speed up the process by making the pull request readable and easy to understand, with diagrams or before/after data. +* You are going to be expected to document all your changes in the pull request. Failing to do so will mean delaying it as we will have to question why you made the change. On the other hand, you can speed up the process by making the pull request readable and easy to understand, with diagrams or before/after data. Should you be optimizing a routine you must provide proof by way of profiling that your changes are faster. * We ask that you use the changelog system to document your change, which prevents our players from being caught unaware by changes - you can find more information about this [on this wiki page](http://tgstation13.org/wiki/Guide_to_Changelogs).