From b91c7a976b189cada0b5aed06ada279da9747bb8 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Fri, 25 Dec 2020 08:21:59 +0100 Subject: [PATCH] [MIRROR] Cleans up a circular ref in status effect code (#2313) * Cleans up a circular ref in status effect code, I'm not sure if it's causing harddels, but I don't like it (#55706) * Cleans up a circular ref in status effect code Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> --- code/datums/status_effects/status_effect.dm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/code/datums/status_effects/status_effect.dm b/code/datums/status_effects/status_effect.dm index a6efdd097c1..c7165264527 100644 --- a/code/datums/status_effects/status_effect.dm +++ b/code/datums/status_effects/status_effect.dm @@ -38,6 +38,7 @@ /datum/status_effect/Destroy() STOP_PROCESSING(SSfastprocess, src) if(owner) + linked_alert = null owner.clear_alert(id) LAZYREMOVE(owner.status_effects, src) on_remove() @@ -89,6 +90,10 @@ desc = "You don't feel any different..." var/datum/status_effect/attached_effect +/atom/movable/screen/alert/status_effect/Destroy() + attached_effect = null //Don't keep a ref now + return ..() + ////////////////// // HELPER PROCS // //////////////////