More standardization for ghost notifications (READY) (#79596)

## About The Pull Request
I'm still not satisfied with how ghost notifications work. This gives
every notification with a source (99% of all notifications, in other
words) a link to jump/orbit. Currently, notifications with "play"
interactions would only get the interact link, so jumping to the source
was pretty annoying.

It removes posting the entire message in the alert tooltip, as some got
pretty lengthy and it didn't seem to fit. To replace this, they will
always use headers

After:


![image](https://github.com/tgstation/tgstation/assets/42397676/debfce52-3627-4a43-8663-33d61d893161)


![image](https://github.com/tgstation/tgstation/assets/42397676/01f299ae-dc6a-45f8-a97a-cb2c815088b2)


![image](https://github.com/tgstation/tgstation/assets/42397676/99567376-063e-458e-af2a-2dd4306747cc)

NOTIFY_JUMP and NOTIFY_ORBIT have been merged, since the only difference
seems to be whether it's a turf. The result shaves off some redundant
lines of code, since most-every usage of notify_ghosts uses
NOTIFY_ORBIT.
## Why It's Good For The Game
More standardization for the ghost notification system. Adds a few alert
headers that never had them. All in all, makes it easier for creators to
throw alerts at ghosts
## Changelog
🆑
qol: Nearly every ghost alert should now feature a "VIEW" button, even
those with click interaction.
del: Ghost alerts no longer show the entire message in the tooltip,
instead have been replaced with titles.
/🆑
This commit is contained in:
Jeremiah
2023-11-19 05:13:25 +01:00
committed by GitHub
parent 7a1b1fa9ad
commit bbe440b3d6
54 changed files with 99 additions and 148 deletions
@@ -26,9 +26,10 @@
notify_ghosts(
"\A golem shell has been completed in \the [init_area.name].",
source = src,
action = NOTIFY_PLAY,
notify_flags = NOTIFY_CATEGORY_NOFLASH,
header = "Golem Shell",
click_interact = TRUE,
ignore_key = POLL_IGNORE_GOLEM,
notify_flags = NOTIFY_CATEGORY_NOFLASH,
)
/obj/effect/mob_spawn/ghost_role/human/golem/name_mob(mob/living/spawned_mob, forced_name)
@@ -256,9 +256,10 @@
notify_ghosts(
"An ash walker egg is ready to hatch in \the [spawner_area.name].",
source = src,
action = NOTIFY_PLAY,
notify_flags = NOTIFY_CATEGORY_NOFLASH,
header = "Ash Walker Egg",
click_interact = TRUE,
ignore_key = POLL_IGNORE_ASHWALKER,
notify_flags = NOTIFY_CATEGORY_NOFLASH,
)
/datum/outfit/ashwalker
@@ -113,7 +113,8 @@
notify_ghosts(
"[src] is ready to hatch!",
source = src,
action = NOTIFY_PLAY,
header = "Spider Infestation",
click_interact = TRUE,
ignore_key = POLL_IGNORE_SPIDER,
notify_flags = notify_flags_to_pass,
)
@@ -36,7 +36,8 @@
notify_ghosts(
"[src] has borne fruit!",
source = src,
action = NOTIFY_PLAY,
header = "Venus Human Trap",
click_interact = TRUE,
ignore_key = POLL_IGNORE_VENUSHUMANTRAP,
)