From bc38acb20669a3c5c5cc34f2f74b4f2a1bdbd2a0 Mon Sep 17 00:00:00 2001 From: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Date: Wed, 14 Jun 2023 01:09:32 -0500 Subject: [PATCH] Adds some parenthesis to some bitwise operations (#76002) ## About The Pull Request A set of parenthesis a day keeps weird order of operations away ## Why It's Good For The Game Might be causing bugs? ## Changelog :cl: Melbert fix: Maybe fixes minor bugs in disease cure, revolution, hooded suit code /:cl: --- code/datums/diseases/_disease.dm | 2 +- code/modules/antagonists/revolution/revolution.dm | 2 +- code/modules/clothing/suits/toggles.dm | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/code/datums/diseases/_disease.dm b/code/datums/diseases/_disease.dm index 67e039d8237..88a4b54c711 100644 --- a/code/datums/diseases/_disease.dm +++ b/code/datums/diseases/_disease.dm @@ -87,7 +87,7 @@ stage = new_stage /datum/disease/proc/has_cure() - if(!(disease_flags & CURABLE | CHRONIC)) + if(!(disease_flags & (CURABLE | CHRONIC))) return FALSE . = cures.len diff --git a/code/modules/antagonists/revolution/revolution.dm b/code/modules/antagonists/revolution/revolution.dm index 6d5885a77c2..31cab0c2ba6 100644 --- a/code/modules/antagonists/revolution/revolution.dm +++ b/code/modules/antagonists/revolution/revolution.dm @@ -563,7 +563,7 @@ player.med_hud_set_status() for(var/datum/job/job as anything in SSjob.joinable_occupations) - if(!(job.departments_bitflags & DEPARTMENT_BITFLAG_SECURITY|DEPARTMENT_BITFLAG_COMMAND)) + if(!(job.departments_bitflags & (DEPARTMENT_BITFLAG_SECURITY|DEPARTMENT_BITFLAG_COMMAND))) continue job.allow_bureaucratic_error = FALSE job.total_positions = 0 diff --git a/code/modules/clothing/suits/toggles.dm b/code/modules/clothing/suits/toggles.dm index 6a7cfb72642..75d684333d3 100644 --- a/code/modules/clothing/suits/toggles.dm +++ b/code/modules/clothing/suits/toggles.dm @@ -33,11 +33,11 @@ ToggleHood() /obj/item/clothing/suit/hooded/item_action_slot_check(slot, mob/user) - if(slot & ITEM_SLOT_OCLOTHING|ITEM_SLOT_NECK) + if(slot & (ITEM_SLOT_OCLOTHING|ITEM_SLOT_NECK)) return TRUE /obj/item/clothing/suit/hooded/equipped(mob/user, slot) - if(!(slot & ITEM_SLOT_OCLOTHING|ITEM_SLOT_NECK)) + if(!(slot & (ITEM_SLOT_OCLOTHING|ITEM_SLOT_NECK))) RemoveHood() return ..()