From bdb264acdf1b99c0e680dbf87a9218297d49da4e Mon Sep 17 00:00:00 2001 From: MrStonedOne Date: Sat, 11 Jul 2015 23:09:04 -0700 Subject: [PATCH] Removes topic limiter. Topics are no longer limited to once per 2ds per client. This massively improves responsiveness by no dropping clicks when trying to browse thru menus. Anything that could cause lag or otherwise be limited should do that in its own topic, not blog down the rest Please let me know if you can think of anything that should be limited in this PR otherwise, i say we find out by field testing. --- code/modules/client/client defines.dm | 2 -- code/modules/client/client procs.dm | 6 ------ 2 files changed, 8 deletions(-) diff --git a/code/modules/client/client defines.dm b/code/modules/client/client defines.dm index 14a2b5bdaf9..2e41bb6717e 100644 --- a/code/modules/client/client defines.dm +++ b/code/modules/client/client defines.dm @@ -26,11 +26,9 @@ //////////// //SECURITY// //////////// - var/next_allowed_topic_time = 10 // comment out the line below when debugging locally to enable the options & messages menu control_freak = 1 - //////////////////////////////////// //things that require the database// //////////////////////////////////// diff --git a/code/modules/client/client procs.dm b/code/modules/client/client procs.dm index 1d4fe387de0..30a82a92f63 100644 --- a/code/modules/client/client procs.dm +++ b/code/modules/client/client procs.dm @@ -1,7 +1,6 @@ //////////// //SECURITY// //////////// -#define TOPIC_SPAM_DELAY 2 //2 ticks is about 2/10ths of a second; it was 4 ticks, but that caused too many clicks to be lost due to lag #define UPLOAD_LIMIT 1048576 //Restricts client uploads to the server to 1MB //Could probably do with being lower. #define MIN_CLIENT_VERSION 0 //Just an ambiguously low version for now, I don't want to suddenly stop people playing. //I would just like the code ready should it ever need to be used. @@ -24,11 +23,6 @@ if(!usr || usr != mob) //stops us calling Topic for somebody else's client. Also helps prevent usr=null return - //Reduces spamming of links by dropping calls that happen during the delay period - if(next_allowed_topic_time > world.time) - return - next_allowed_topic_time = world.time + TOPIC_SPAM_DELAY - //Admin PM if(href_list["priv_msg"]) if (href_list["ahelp_reply"])