From bddfeacc6407e8d3d6fc2e9f165e9f79c9cdb925 Mon Sep 17 00:00:00 2001 From: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Date: Mon, 17 Apr 2023 11:42:53 +0530 Subject: [PATCH] [No GBP]Fixes runtimes when deconstructing floor tiles with RTD (#74767) ## About The Pull Request Fixes this ![Screenshot (161)](https://user-images.githubusercontent.com/110812394/232286754-cde879e1-4593-4104-9392-2cc80b845334.png) Caused by this ![Screenshot (162)](https://user-images.githubusercontent.com/110812394/232286901-d16b055e-32e0-4ed9-9caf-35bb229ae62e.png) Since the RTD deconstructs i.e. QDEL the floor tile, the animation effect tried to add a timer to QDEL itself on the deleted floor tile causing the runtime. ## Changelog :cl: fix: RTD animation effect adding a timer on deleted floor tiles. /:cl: --------- Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com> --- code/game/objects/items/rcd/RTD.dm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/code/game/objects/items/rcd/RTD.dm b/code/game/objects/items/rcd/RTD.dm index 5d318ad6e11..9141e77ae95 100644 --- a/code/game/objects/items/rcd/RTD.dm +++ b/code/game/objects/items/rcd/RTD.dm @@ -328,7 +328,7 @@ return SECONDARY_ATTACK_CANCEL_ATTACK_CHAIN var/delay = DECONSTRUCTION_TIME(cost) - var/obj/effect/constructing_effect/rcd_effect = new(floor, delay, RCD_FLOORWALL) + var/obj/effect/constructing_effect/rcd_effect = new(floor, delay, RCD_DECONSTRUCT) //resource sanity check before & after delay along with beam effects if(!checkResource(cost * 0.7, user)) //no ballon alert for checkResource as it already spans an alert to chat @@ -359,7 +359,7 @@ qdel(decal) if(floor.baseturf_at_depth(1) == /turf/baseturf_bottom) //for turfs whose base is open space we put regular plating in its place else everyone dies floor.ChangeTurf(/turf/open/floor/plating, flags = CHANGETURF_INHERIT_AIR) - else // for every other turf we scarp away exposing base turf underneath + else //for every other turf we scrape away exposing base turf underneath floor.ScrapeAway(flags = CHANGETURF_INHERIT_AIR) rcd_effect.end_animation()