cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2025-12-10 17:52:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stops trying to update slot icons for qdeleted mobs (#93657)

Browse Source 
## About The Pull Request

Another found runtime

<img width="1012" height="30" alt="image"
src="https://github.com/user-attachments/assets/b9cc4e6f-b962-4f44-a158-1077ee449716"
/>

<img width="958" height="511" alt="avsfvHfCR5"
src="https://github.com/user-attachments/assets/4b0746eb-b074-4a8d-bcb8-5b215babffa6"
/>

When a decal element is detached, it asynchronously invokes
update_slot_icon. Including when it gets deleted.

<img width="742" height="163" alt="image"
src="https://github.com/user-attachments/assets/b8c26d92-0699-4638-aebe-0dc5a26ad12d"
/>

Which leads to a chain of unnecessary proccalls until eventually one
runtimes.

## Why It's Good For The Game

Removes a lot of needless proc calls from the stack.

## Changelog

Not player facing
This commit is contained in:
Bloop
2025-10-28 19:58:09 -04:00
committed by GitHub
parent c173f898f8
commit bfc8cf5f3a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
code/game/objects/items.dm
View File

@@ -975,7 +975,7 @@
/obj/item/proc/update_slot_icon() /obj/item/proc/update_slot_icon()
SIGNAL_HANDLER SIGNAL_HANDLER
if(!ismob(loc)) if(!ismob(loc) || QDELETED(loc))
return return
var/mob/owner = loc var/mob/owner = loc
owner.update_clothing(slot_flags | owner.get_slot_by_item(src)) owner.update_clothing(slot_flags | owner.get_slot_by_item(src))