[MIRROR] A few records-related manual mirrors (so I don't have to deal with annoying conflicts) (#19588)

* Records: Clerical expansion (#73022)

A few changes to sec records geared towards making it obvious how and
why someone is wanted.

- You can no longer set someone to arrest via console unless they have a
valid prior.
- Setting players to arrest via HUD creates a crime entry for that
person.
- Priors can be edited by the author and qualified personnel (armory
access).
- Priors can be invalidated by qualified personnel. This redacts the
info from huds and rapsheets.
- Invalidating the last crime sets a player to discharged
- Much like real life, you can no longer outright delete crimes. This
prevents gaming the arrest system by adding/deleting.
- Deleting an individual record in a sec console removes it from the
manifest (@JohnFulpWillard) this was previous behavior
- Purging records in sec requires higher access

Have you ever brought a wanted person into the brig only to find there's
no reasons listed and no one in sec will explain why they're wanted?
🆑
fix: Deleting a sec record removes it from the manifest again
qol: It's now easier to see security notes via HUD.
qol: It's now easier to see why someone is set to arrest.
qol: Crime authors and armory access can edit crimes.
balance: Setting players to arrest requires a valid crime.
balance: Armory access can invalidate priors.
balance: Setting players to arrest via HUD creates a crime for the
suspect.
/🆑

---------

Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
Co-authored-by: san7890 <the@san7890.com>

* Records hotfix [NO GBP] (#73363)

A remake of #73169
Repaths records consoles to their own subtype
Fixes some weirdness with observers logging into sec/med consoles
Fixes security notes not being able to be set etc

Bug fixes and cleaner code

🆑
fix: Security can set notes through consoles again
fix: Observers are now properly logged out of record consoles
/🆑

---------

Co-authored-by: Jeremiah <jlsnow301@pm.me>

* Fixes the map merge conflicts, hopefully.

* Fixes player created security records being unprintable for wanted/missing posters. (#73666)

## About The Pull Request

If a player created a security record during a round and attempted to
print it the printing process would runtime and result in the printer
being unusable.

As a side effect of fixing this I've discovered an annoying bug with
posters with them defaulting to the bottom left corner of a record. So
currently mugshot uploads has been restricted to 32x32 pixels with
approval from @jlsnow301 . Ideally at some point a player exposed photo
cropping system can be implemented to make it easier to create mugshots
using larger photos.

## Why It's Good For The Game

Fixes a bug.

## Changelog
🆑
fix: You can now create wanted/missing posters using player created
security records. Due to a visual bug and usability issue photos above 1
by 1 meters in size will no longer work for mugshots in records.
/🆑

* Fixes ui_data on ntosrecords [NO GBP] (#73670)

## About The Pull Request
Missed this while redoing records, this makes it match what the UI is
expecting
## Why It's Good For The Game
Bug fixes
## Changelog
🆑
fix: Fixes NTOS records program receiving bad medical disability data
/🆑

Co-authored-by: Jeremiah <jlsnow301@pm.me>
Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>

* Updates all of our maps with the new records computer paths

* Actually I don't know where this came from but I think it'll fix the linters

* Okay now it should work properly, hopefully

* mapas

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: Iamgoofball <iamgoofball@gmail.com>
Co-authored-by: san7890 <the@san7890.com>
Co-authored-by: Jeremiah <jlsnow301@pm.me>
Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com>
Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
This commit is contained in:
GoldenAlpharex
2023-03-10 02:42:52 +00:00
committed by GitHub
co-authored by Jeremiah Jeremiah Iamgoofball san7890 NamelessFairy Jolly-66 Gandalf
parent 50871407e4
commit c040ddb857
50 changed files with 7527 additions and 7294 deletions
@@ -53,7 +53,7 @@
current_record["bloodtype"] = person.blood_type
current_record["ma_dis"] = person.major_disabilities_desc
current_record["minor_disabilities"] = person.minor_disabilities_desc
current_record["mi_dis"] = person.minor_disabilities_desc
current_record["name"] = person.name
current_record["notes"] = person.medical_notes