From c0bdfaf7770073d8b5d1bc43c595d1ee6b880599 Mon Sep 17 00:00:00 2001
From: SkyratBot <59378654+SkyratBot@users.noreply.github.com>
Date: Sun, 13 Dec 2020 14:44:20 +0100
Subject: [PATCH] [MIRROR] Fixes an oversight allowing players to list ckeys
 and the names of the mobs they're controlling under certain conditions
 (#2158)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions (#55332)

About The Pull Request

• Resolves a probably unknown oversight allowing players to find out who plays who by using the ignore verb, which if the user is a ghost, will list the names of people's mobs alongside their ckey if they are also a ghost.
Why It's Good For The Game

Removes a potential method of metagrudging and addresses a privacy concern for those who wish to play anonymous characters. Yes, you can still see this stuff in the round-end report.
We don't lose anything here. If we're using this verb, we're doing it because we want to ignore someone's OOC messages. We don't need this additional information. I feel like this is just an oversight.
Changelog

🆑
fix: Players can no longer us the ignore verb to gather a list of people's characters and ckeys together.
/🆑

* Fixes an oversight allowing players to list ckeys and the names of the mobs they're controlling under certain conditions

Co-authored-by: KathrinBailey <53862927+KathrinBailey@users.noreply.github.com>
---
 code/modules/client/verbs/ooc.dm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/modules/client/verbs/ooc.dm b/code/modules/client/verbs/ooc.dm
index d3139e988e5..edc27c50baa 100644
--- a/code/modules/client/verbs/ooc.dm
+++ b/code/modules/client/verbs/ooc.dm
@@ -250,9 +250,9 @@ GLOBAL_VAR_INIT(normal_ooc_colour, "#002eb8")
 
 		// Check if both we and the player are ghosts and they're not using a fakekey
 		if(isobserver(mob) && isobserver(C.mob) && !C.holder?.fakekey)
-			// Show us the player's mob name in the list in front of their displayed key
+			// Show us if the player is a ghost or not after their displayed key
 			// Add the player's displayed key to the list
-			players["[C.mob]([displayed_key])"] = displayed_key
+			players["[displayed_key](ghost)"] = displayed_key
 
 		// Add the player's displayed key to the list if we or the player aren't a ghost or they're using a fakekey
 		else