mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-26 14:39:58 +01:00
Multiload Second Pass (ft. Speedloaders Will Be Real In 2025) (#92854)
## About The Pull Request Gets, yet again, more granular with multiload capabilities, by introducing `AMMO_BOX_MULTILOAD_OUT_LOADED`; ammo boxes flagged with this can speed-load ammo boxes that are currently inside another gun, like revolver cylinders or internal magazines. To accomodate for this, the previous flag that covered this, `AMMO_BOX_MULTILOAD_OUT` can no longer speedload into currently loaded magazines (e.g. internal magazines, including revolver cylinders). Also implements a base type for speedloaders, moving .38 and .357 speedloaders along with .310 stripper clips to this type, instead of being ammo boxes. Also features an UpdatePaths script for mappers, which is why there's so many files touched - repathing is a pain. Also also adds fancy types for ammo boxes, magazines, and speedloaders, which isn't particularly player-facing. Also also also makes the lionhunter ammo strip for the lionhunter rifle visually three rounds only instead of being perpetually half-full (or half-empty, depending on your pessimism). ## Why It's Good For The Game The hypothetical case of "ammo box that holds shotgun ammo" should probably... not... teleport as much of its ammo as possible into a tube-fed shotgun, but should probably still be okay at reloading magazines that actually go into shotguns. Or something. More relevant, reloading BR-38 magazines with speedloaders, while funny, probably also shouldn't be teleporting in six fresh rounds. ## Changelog 🆑 balance: General ammo boxes (not speedloaders, not stripper clips) can no longer multiload into currently loaded magazines (revolver cylinders, internal magazines). balance: Speedloaders are now a separate type from ammo boxes, and can only multiload into currently loaded magazines e.g. revolver cylinders. qol: Ammo boxes, magazines, and speedloaders now have fancier types for spawning in by admins. sprite: Lionhunter ammo clips are visually smaller now. /🆑 --------- Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com>
This commit is contained in:
@@ -51,7 +51,7 @@
|
||||
name = ".357 Speed Loader"
|
||||
desc = "A speed loader that contains seven additional .357 Magnum rounds; usable with the Syndicate revolver. \
|
||||
For when you really need a lot of things dead."
|
||||
item = /obj/item/ammo_box/a357
|
||||
item = /obj/item/ammo_box/speedloader/c357
|
||||
cost = 4
|
||||
purchasable_from = ~(UPLINK_ALL_SYNDIE_OPS | UPLINK_SPY) //nukies get their own version
|
||||
uplink_item_flags = SYNDIE_TRIPS_CONTRABAND
|
||||
|
||||
@@ -218,7 +218,7 @@
|
||||
name = ".357 Speed Loader (Revolver)"
|
||||
desc = "A speed loader that contains seven additional .357 Magnum rounds; usable with the Syndicate revolver. \
|
||||
For when you really need a lot of things dead. Unlike field agents, operatives get a premium price for their speedloaders!"
|
||||
item = /obj/item/ammo_box/a357
|
||||
item = /obj/item/ammo_box/speedloader/c357
|
||||
purchasable_from = parent_type::purchasable_from | UPLINK_SPY
|
||||
|
||||
/datum/uplink_item/ammo_nuclear/special/revolver/phasic
|
||||
@@ -226,7 +226,7 @@
|
||||
desc = "A speed loader that contains seven additional .357 Magnum phasic rounds; usable with the Syndicate revolver. \
|
||||
These bullets are made from an experimental alloy, 'Ghost Lead', that allows it to pass through almost any non-organic material. \
|
||||
The name is a misnomer. It doesn't contain any lead whatsoever!"
|
||||
item = /obj/item/ammo_box/a357/phasic
|
||||
item = /obj/item/ammo_box/speedloader/c357/phasic
|
||||
purchasable_from = parent_type::purchasable_from | UPLINK_SPY
|
||||
|
||||
/datum/uplink_item/ammo_nuclear/special/revolver/heartseeker
|
||||
@@ -234,7 +234,7 @@
|
||||
desc = "A speed loader that contains seven additional .357 Magnum heartseeker rounds; usable with the Syndicate revolver. \
|
||||
Able to veer straight into targets! Don't miss a shot with heartseeker! As seen in the hit NTFlik horror-space western film, Forget-Me-Not! \
|
||||
Brought to you by Roseus Galactic!"
|
||||
item = /obj/item/ammo_box/a357/heartseeker
|
||||
item = /obj/item/ammo_box/speedloader/c357/heartseeker
|
||||
cost = 3
|
||||
purchasable_from = parent_type::purchasable_from | UPLINK_SPY
|
||||
|
||||
|
||||
Reference in New Issue
Block a user