cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 08:37:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix hard deletes related to escape menu (#92129)

Browse Source 
## About The Pull Request

`resource_panels` is only emptied if the user collapses the panel by
clicking the expand button again, if they just close the escape menu
with it expanded then refs to all the buttons linger and hard delete

## Why It's Good For The Game

Fix for several hard deletes
```
RUNTIME: ## TESTING: GC: -- [0x2002d13] | /atom/movable/screen/escape_menu/lobby_button/small/collapsible was unable to be GC'd -- (ref count of 3)
RUNTIME: ## TESTING: GC: -- [0x2002259] | /atom/movable/screen/escape_menu/lobby_button/small/collapsible was unable to be GC'd -- (ref count of 3)
RUNTIME: ## TESTING: GC: -- [0x2002414] | /atom/movable/screen/escape_menu/lobby_button/small/collapsible was unable to be GC'd -- (ref count of 3)
RUNTIME: ## TESTING: GC: -- [0x2001e36] | /atom/movable/screen/escape_menu/lobby_button/small/collapsible was unable to be GC'd -- (ref count of 3)
RUNTIME: ## TESTING: GC: -- [0x2007b3b] | /atom/movable/screen/escape_menu/lobby_button/small/collapsible was unable to be GC'd -- (ref count of 3)
RUNTIME: ## TESTING: GC: -- [0x200216d] | /atom/movable/screen/escape_menu/lobby_button/small/collapsible was unable to be GC'd -- (ref count of 3)
```

## Changelog

N/A
This commit is contained in:
Roxy
2025-07-14 16:50:37 -06:00
committed by GitHub
parent c80f36cb40
commit c1ac3dcf8c
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/escape_menu/escape_menu.dm
+1
View File
@@ -66,6 +66,7 @@ GLOBAL_LIST_EMPTY(escape_menus)
/datum/escape_menu/Destroy(force)
QDEL_NULL(base_holder)
QDEL_NULL(page_holder)
resource_panels = null // list contents were already qdeled in QDEL_NULL(page_holder), so we can safely null this
var/datum/our_hud = our_hud_ref?.resolve()
if(our_hud)