cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-24 05:30:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Micro-optimize qdel by only permitting one parameter (#80628)

Browse Source 
Productionizes #80615.

The core optimization is this:

```patch
-	var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up.
+	var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up.
```

We avoid a heap allocation in the form of copying the args over to a new
list. A/B testing shows this results in 33% better overtime, and in a
real round shaving off a full second of self time and 0.4 seconds of
overtime--both of these would be doubled in the event this is merged as
the new proc was only being run 50% of the time.
This commit is contained in:
Mothblocks
2023-12-28 13:52:44 -08:00
committed by GitHub
parent 5dda21371d
commit c1d68698fb
116 changed files with 126 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/datums/components/basic_mob_attack_telegraph.dm
+1 -1
View File
@@ -25,7 +25,7 @@
src.telegraph_duration = telegraph_duration
src.on_began_forecast = on_began_forecast
/datum/component/basic_mob_attack_telegraph/Destroy(force, silent)
/datum/component/basic_mob_attack_telegraph/Destroy(force)
if(current_target)
forget_target(current_target)
target_overlay = null