mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-28 07:38:05 +01:00
Micro-optimize qdel by only permitting one parameter (#80628)
Productionizes #80615. The core optimization is this: ```patch - var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up. + var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up. ``` We avoid a heap allocation in the form of copying the args over to a new list. A/B testing shows this results in 33% better overtime, and in a real round shaving off a full second of self time and 0.4 seconds of overtime--both of these would be doubled in the event this is merged as the new proc was only being run 50% of the time.
This commit is contained in:
@@ -101,7 +101,7 @@
|
||||
|
||||
QDEL_NULL(attached_circuit)
|
||||
|
||||
/datum/component/shell/Destroy(force, silent)
|
||||
/datum/component/shell/Destroy(force)
|
||||
QDEL_LIST(unremovable_circuit_components)
|
||||
return ..()
|
||||
|
||||
|
||||
Reference in New Issue
Block a user