From c2d85f4f75a3e65c3533778704d23ca1bcf68aed Mon Sep 17 00:00:00 2001 From: Fikou Date: Mon, 26 Apr 2021 10:35:52 +0200 Subject: [PATCH] fixes transformation code runtiming (maybe fixes monkey fever???) (#58642) transformation code didnt check if the lists with strings had anything in them, causing a runtime from pick() --- code/datums/diseases/transformation.dm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/code/datums/diseases/transformation.dm b/code/datums/diseases/transformation.dm index 63c44cfa29b..baa400b8172 100644 --- a/code/datums/diseases/transformation.dm +++ b/code/datums/diseases/transformation.dm @@ -37,16 +37,16 @@ switch(stage) if(1) - if (stage1 && DT_PROB(stage_prob, delta_time)) + if (length(stage1) && DT_PROB(stage_prob, delta_time)) to_chat(affected_mob, pick(stage1)) if(2) - if (stage2 && DT_PROB(stage_prob, delta_time)) + if (length(stage2) && DT_PROB(stage_prob, delta_time)) to_chat(affected_mob, pick(stage2)) if(3) - if (stage3 && DT_PROB(stage_prob * 2, delta_time)) + if (length(stage3) && DT_PROB(stage_prob * 2, delta_time)) to_chat(affected_mob, pick(stage3)) if(4) - if (stage4 && DT_PROB(stage_prob * 2, delta_time)) + if (length(stage4) && DT_PROB(stage_prob * 2, delta_time)) to_chat(affected_mob, pick(stage4)) if(5) do_disease_transformation(affected_mob) @@ -54,7 +54,7 @@ /datum/disease/transformation/proc/do_disease_transformation(mob/living/affected_mob) if(istype(affected_mob, /mob/living/carbon) && affected_mob.stat != DEAD) - if(stage5) + if(length(stage5)) to_chat(affected_mob, pick(stage5)) if(QDELETED(affected_mob)) return