mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-24 21:48:39 +01:00
Wraps lowertext() to ensure proper stringification. (#82442)
## About The Pull Request Fixes #82440 This PR just creates a new macro, `LOWER_TEXT()` (yes the irony is not lost on me) to wrap around all calls of `lowertext()` and ensure that whatever we input into that proc will be stringified using the `"[]"` (or `tostring()` for the nerds) operator. very simple. I also added a linter to enforce this (and prevent all forms of regression) because I think that machines should do the menial work and we shouldn't expect maintainers to remember this, let me know if you disagree. if there is a time when it should be opted out for some reason, the linter does respect it if you wrap your input with the `UNLINT()` function.
This commit is contained in:
@@ -392,7 +392,7 @@
|
||||
|
||||
if(istype(character, /datum/mind))
|
||||
var/datum/mind/character_mind = character
|
||||
return "\the [lowertext(initial(character_mind.assigned_role.title))]"
|
||||
return "\the [LOWER_TEXT(initial(character_mind.assigned_role.title))]"
|
||||
|
||||
// Generic result - mobs get "the guy", objs / turfs get "a thing"
|
||||
return ismob(character) ? "\the [character]" : "\a [character]"
|
||||
|
||||
Reference in New Issue
Block a user