mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-23 05:00:55 +01:00
Wraps lowertext() to ensure proper stringification. (#82442)
## About The Pull Request Fixes #82440 This PR just creates a new macro, `LOWER_TEXT()` (yes the irony is not lost on me) to wrap around all calls of `lowertext()` and ensure that whatever we input into that proc will be stringified using the `"[]"` (or `tostring()` for the nerds) operator. very simple. I also added a linter to enforce this (and prevent all forms of regression) because I think that machines should do the menial work and we shouldn't expect maintainers to remember this, let me know if you disagree. if there is a time when it should be opted out for some reason, the linter does respect it if you wrap your input with the `UNLINT()` function.
This commit is contained in:
@@ -48,7 +48,7 @@
|
||||
var/Y = rand(FLOOR(syllable_count/syllable_divisor, 1), syllable_count)
|
||||
for(var/x in Y to 0)
|
||||
new_name += pick_weight_recursive(syllables)
|
||||
full_name += " [capitalize(lowertext(new_name))]"
|
||||
full_name += " [capitalize(LOWER_TEXT(new_name))]"
|
||||
|
||||
return "[trim(full_name)]"
|
||||
|
||||
|
||||
Reference in New Issue
Block a user