Cyborgs now use storage datum (#90927)

## About The Pull Request

This moves Cyborgs onto using storage datums, removing the remenants of
the shitcode that was Cyborg inventory. It's now done mostly by
equipping/unequipping/storage items, much like how other mobs do.
This allows borgs to take advantage of more hand support stuff and
things like ``dropped()``, so borgs no longer have to copy paste drop
code to ``cyborg_unequip``

It also:
- Removes ``CYBORG_ITEM_TRAIT``
- Removes all borg items being ``NODROP``


https://github.com/user-attachments/assets/11442a10-3443-41f2-8c72-b38fb0126cdb

## Why It's Good For The Game

Currently borgs are able to have their entire inventory open and a bag
below it, which I thought was a little weird. I always assumed they WERE
storage items, so I guess I'm doing it myself.
Cyborgs using storage code makes it easier for contributors to actually
do stuff with, without risking breaking everything. It also hopefully
will make borg items more resilient against breaking in the future, now
that we're not relying on nodrop.
Also just brings them more in line with other mobs, all of which make
use of storages.

## Changelog

🆑
refactor: Cyborg's modules now use storage (so opening a bag will close
modules instead of overlap one over the other).
qol: Observers can now see Cyborg's inventories (like they can for
humans).
/🆑

---------

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>

code/datums/storage/storage_interface.dm

@@ -13,25 +13,27 @@
 	/// Storage that owns us
 	var/datum/storage/parent_storage
 
-/datum/storage_interface/New(ui_style, parent_storage)
+/datum/storage_interface/New(ui_style, datum/storage/parent_storage, mob/user)
 	..()
 	src.parent_storage = parent_storage
-	closer = new(null, null, parent_storage)
-	cells = new(null, null, parent_storage)
-	corner_top_left = new(null, null, parent_storage)
-	corner_top_right = new(null, null, parent_storage)
-	corner_bottom_left = new(null, null, parent_storage)
-	corner_bottom_right = new(null, null, parent_storage)
-	rowjoin_left = new(null, null, parent_storage)
-	rowjoin_right = new(null, null, parent_storage)
-	for (var/atom/movable/screen/ui_elem as anything in list_ui_elements())
+	var/datum/hud/owner_hud = user.hud_used
+	closer = new(null, owner_hud, parent_storage)
+	cells = new(null, owner_hud, parent_storage)
+	corner_top_left = new(null, owner_hud, parent_storage)
+	corner_top_right = new(null, owner_hud, parent_storage)
+	corner_bottom_left = new(null, owner_hud, parent_storage)
+	corner_bottom_right = new(null, owner_hud, parent_storage)
+	rowjoin_left = new(null, owner_hud, parent_storage)
+	rowjoin_right = new(null, owner_hud, parent_storage)
+	for (var/atom/movable/screen/ui_elem as anything in list_ui_elements(initializing = TRUE))
 		ui_elem.icon = ui_style
 
 /// Returns all UI elements under this theme
-/datum/storage_interface/proc/list_ui_elements()
+/datum/storage_interface/proc/list_ui_elements(initializing = FALSE)
 	return list(cells, corner_top_left, corner_top_right, corner_bottom_left, corner_bottom_right, rowjoin_left, rowjoin_right, closer)
 
 /datum/storage_interface/Destroy(force)
+	QDEL_NULL(closer)
 	QDEL_NULL(cells)
 	QDEL_NULL(corner_top_left)
 	QDEL_NULL(corner_top_right)
@@ -81,6 +83,20 @@
 
 	closer.screen_loc = "[screen_start_x + columns]:[screen_pixel_x - 5],[screen_start_y]:[screen_pixel_y]"
 
+	add_items(arglist(args))
+
+/datum/storage_interface/proc/add_items(
+	screen_start_x,
+	screen_pixel_x,
+	screen_start_y,
+	screen_pixel_y,
+	columns,
+	rows,
+	mob/user_looking,
+	atom/real_location,
+	list/datum/numbered_display/numbered_contents,
+)
+
 	var/current_x = screen_start_x
 	var/current_y = screen_start_y
 	var/turf/our_turf = get_turf(real_location)
@@ -107,3 +123,67 @@
 		current_y++
 		if(current_y - screen_start_y >= rows)
 			break
+
+///Silicon subtype of storage interface used by their model storage.
+/datum/storage_interface/silicon
+	var/atom/movable/screen/robot/store/store
+	var/obj/item/robot_model/robot_model
+
+/datum/storage_interface/silicon/New(ui_style, datum/storage/parent_storage, mob/user)
+	. = ..()
+	robot_model = parent_storage.real_location
+	if(iscyborg(user))
+		store = new(null, user.hud_used)
+
+/datum/storage_interface/silicon/Destroy(force)
+	QDEL_NULL(store)
+	return ..()
+
+/datum/storage_interface/silicon/list_ui_elements(initializing = FALSE)
+	if(initializing || isnull(store))
+		return ..()
+	//we're purposely excluding 'store' from having its icon changed from initialization.
+	return ..() + store
+
+/datum/storage_interface/silicon/add_items(
+	screen_start_x,
+	screen_pixel_x,
+	screen_start_y,
+	screen_pixel_y,
+	columns,
+	rows,
+	mob/user_looking,
+	atom/real_location,
+	list/datum/numbered_display/numbered_contents,
+)
+	var/list/usable_modules = robot_model.get_usable_modules()
+
+	var/current_x = screen_start_x
+	var/current_y = screen_start_y
+	var/turf/our_turf = get_turf(real_location)
+
+	for(var/i in 1 to length(usable_modules))
+		var/atom/movable/item = usable_modules[i]
+		if(item in robot_model.robot.held_items)
+			current_x++
+			if(current_x - screen_start_x < columns)
+				continue
+			current_x = screen_start_x
+
+			current_y++
+			if(current_y - screen_start_y >= rows)
+				break
+			//Module is currently active
+			continue
+
+		item.mouse_opacity = MOUSE_OPACITY_OPAQUE
+		SET_PLANE(item, ABOVE_HUD_PLANE, our_turf)
+		item.screen_loc = "[current_x]:[screen_pixel_x],[current_y]:[screen_pixel_y]"
+
+		current_x++
+		if(current_x - screen_start_x < columns)
+			continue
+		current_x = screen_start_x
+		current_y++
+		if(current_y - screen_start_y >= rows)
+			break