From c710b70b0a16cfae2219ef31f29bbc501abc7cb1 Mon Sep 17 00:00:00 2001 From: SkyratBot <59378654+SkyratBot@users.noreply.github.com> Date: Thu, 28 Jan 2021 02:48:29 +0100 Subject: [PATCH] [MIRROR] removes useless helper proc because SIGN() exists (#2905) * removes num2sign (#56433) * removes useless helper proc because SIGN() exists Co-authored-by: ZeWaka --- code/__HELPERS/cmp.dm | 4 ++-- code/__HELPERS/unsorted.dm | 9 --------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/code/__HELPERS/cmp.dm b/code/__HELPERS/cmp.dm index b79dd1fb47c..7cdb951990f 100644 --- a/code/__HELPERS/cmp.dm +++ b/code/__HELPERS/cmp.dm @@ -93,8 +93,8 @@ GLOBAL_VAR_INIT(cmp_field, "name") return A.totalResistance() - B.totalResistance() /proc/cmp_quirk_asc(datum/quirk/A, datum/quirk/B) - var/a_sign = num2sign(initial(A.value) * -1) - var/b_sign = num2sign(initial(B.value) * -1) + var/a_sign = SIGN(initial(A.value) * -1) + var/b_sign = SIGN(initial(B.value) * -1) // Neutral traits go last. if(a_sign == 0) diff --git a/code/__HELPERS/unsorted.dm b/code/__HELPERS/unsorted.dm index 072821d4d0d..d07636a8b0e 100644 --- a/code/__HELPERS/unsorted.dm +++ b/code/__HELPERS/unsorted.dm @@ -1436,15 +1436,6 @@ GLOBAL_DATUM_INIT(dview_mob, /mob/dview, new) for(var/i in 1 to items_list[each_item]) new each_item(where_to) - -/proc/num2sign(numeric) - if(numeric > 0) - return 1 - else if(numeric < 0) - return -1 - else - return 0 - /proc/CallAsync(datum/source, proctype, list/arguments) set waitfor = FALSE return call(source, proctype)(arglist(arguments))