cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-08-30 00:29:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

[MIRROR] Refactors team antagonists and roundend report handling [MDB IGNORE] (#16308)

Browse Source 
* Refactors team antagonists and roundend report handling (#69585)

* Refactors team antagonists and roundend report handling

Refactors teams and subtypes
* Makes use of ``as anything`` and ``\improper``
* Removes many single letter variables
* Moves team code to the team file
* Makes team objectives only allow objectives for SpacemanDMM
* Makes members and objectives clear when a team is deleted
* Generalizes team's add_objective
* Checks for show_roundend_report in roundend
* Replaces ``get_team == src`` with a simple mind check
* Makes Bloodbrothers fit using parent's endround report.
* Removes the unused procs ``is_solo`` and ``antag_listing_footer``
* Makes replaces ``get_team_antag`` ``specific`` with ``include_subtypes`` to be consistent with Antag helpers (and because I thought it looked better that way)

* Refactors team antagonists and roundend report handling

* improper borers

Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: tastyfish <crazychris32@gmail.com>
This commit is contained in:
SkyratBot
2022-09-23 22:29:34 -04:00
committed by GitHub
co-authored by John Willard tastyfish
parent 44fb03430e
commit c8776ecbbb
13 changed files with 114 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/admin/check_antagonists.dm
-29
View File
@@ -48,35 +48,6 @@
parts += antag_listing_commands()
return "<tr><td>[parts.Join("</td><td>")]</td></tr>"
/datum/team/proc/get_team_antags(antag_type,specific = FALSE)
. = list()
for(var/datum/antagonist/A in GLOB.antagonists)
if(A.get_team() == src && (!antag_type || !specific && istype(A,antag_type) || specific && A.type == antag_type))
. += A
//Builds section for the team
/datum/team/proc/antag_listing_entry()
//NukeOps:
// Jim (Status) FLW PM TP
// Joe (Status) FLW PM TP
//Disk:
// Deep Space FLW
var/list/parts = list()
parts += "<b>[antag_listing_name()]</b><br>"
parts += "<table cellspacing=5>"
for(var/datum/antagonist/A in get_team_antags())
parts += A.antag_listing_entry()
parts += "</table>"
parts += antag_listing_footer()
return parts.Join()
/datum/team/proc/antag_listing_name()
return name
/datum/team/proc/antag_listing_footer()
return
/datum/admins/proc/build_antag_listing()
var/list/sections = list()
var/list/priority_sections = list()